Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbaDOGfJ (ORCPT ); Tue, 15 Apr 2014 02:35:09 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:40471 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbaDOGfH (ORCPT ); Tue, 15 Apr 2014 02:35:07 -0400 MIME-Version: 1.0 In-Reply-To: <534BD810.3010705@ti.com> References: <1397266245-3144-1-git-send-email-realmz6@kernel.org> <534BD810.3010705@ti.com> Date: Tue, 15 Apr 2014 14:35:06 +0800 Message-ID: Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error From: Steven Miao To: Tomi Valkeinen Cc: Steven Miao , Jean-Christophe Plagniol-Villard , bfin , "open list:CAN NETWORK DRIVERS , open list:NETWORKING DRIVERS , open list" , linux-fbdev@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, On Mon, Apr 14, 2014 at 8:44 PM, Tomi Valkeinen wrote: > On 12/04/14 04:30, Steven Miao wrote: >> From: Steven Miao >> >> should include linux/gpio.h >> >> Signed-off-by: Steven Miao >> --- >> drivers/video/bf54x-lq043fb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c >> index 42b8f9d..d2b54f1 100644 >> --- a/drivers/video/bf54x-lq043fb.c >> +++ b/drivers/video/bf54x-lq043fb.c >> @@ -49,6 +49,7 @@ >> #include >> #include >> #include >> +#include > > The driver includes . I think that should be removed, and > should be used. Yes, it should be removed. > > Can you also remove the asm/gpio.h in your patch, and see if it compiles > fine? I have tested it, it's fine. I'll resend the patch. > > Tomi > > -steven -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/