Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbaDOH4q (ORCPT ); Tue, 15 Apr 2014 03:56:46 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:42485 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbaDOH4m (ORCPT ); Tue, 15 Apr 2014 03:56:42 -0400 MIME-Version: 1.0 In-Reply-To: <20140414211106.GC12304@sirena.org.uk> References: <1397462949-22379-1-git-send-email-k.kozlowski@samsung.com> <1397462949-22379-5-git-send-email-k.kozlowski@samsung.com> <20140414211106.GC12304@sirena.org.uk> Date: Tue, 15 Apr 2014 13:26:41 +0530 Message-ID: Subject: Re: [PATCH 4/4] regulator: s5m8767: Use same binding for external control as in s2mps11 From: Sachin Kamat To: Mark Brown Cc: Krzysztof Kozlowski , Sangbeom Kim , Liam Girdwood , Samuel Ortiz , Lee Jones , LKML , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , linux-samsung-soc , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , Tomasz Figa Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 April 2014 02:41, Mark Brown wrote: > On Mon, Apr 14, 2014 at 10:09:09AM +0200, Krzysztof Kozlowski wrote: > >> - - s5m8767,pmic-ext-control-gpios: (optional) GPIO specifier for one >> + - samsung,ext-control-gpios: (optional) GPIO specifier for one >> GPIO controlling this regulator (enable/disable); This is >> valid only for buck9. > > This is an incompatible change. It's OK to deprecate the old property > but it's bad form to just remove it. I agree with Mark. Also, there is no need to make it generic. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/