Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbaDOIdr (ORCPT ); Tue, 15 Apr 2014 04:33:47 -0400 Received: from mail-we0-f178.google.com ([74.125.82.178]:53849 "EHLO mail-we0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbaDOIdp (ORCPT ); Tue, 15 Apr 2014 04:33:45 -0400 MIME-Version: 1.0 In-Reply-To: <534CED5B.2090100@hitachi.com> References: <1397472050-19947-1-git-send-email-nasa4836@gmail.com> <534BF7FE.6050603@hitachi.com> <534CED5B.2090100@hitachi.com> From: Zhan Jianyu Date: Tue, 15 Apr 2014 16:33:03 +0800 Message-ID: Subject: Re: [PATCH] kprobes: be more permissive when user specifies both symbol name and address To: Masami Hiramatsu Cc: ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, David Miller , rdunlap@infradead.org, linux-doc@vger.kernel.org, LKML , "yrl.pp-manager.tt@hitachi.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 15, 2014 at 4:27 PM, Masami Hiramatsu wrote: > > Plus, if the p->offset and offs are different, fail too. Oh, yeah, I have did this check it patch too. BTW, I found that the offset has different types in kallsyms_lookup(which is unsigned long) and in struct kprobe(which is unsigned int) Regards, Jianyu Zhan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/