Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbaDOLED (ORCPT ); Tue, 15 Apr 2014 07:04:03 -0400 Received: from sema.semaphore.gr ([78.46.194.137]:56246 "EHLO sema.semaphore.gr" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753164AbaDOLEA (ORCPT ); Tue, 15 Apr 2014 07:04:00 -0400 Message-ID: <534D121D.9030304@semaphore.gr> Date: Tue, 15 Apr 2014 14:03:57 +0300 From: Stratos Karafotis User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J. Wysocki" , "David S. Miller" , Hans-Christian Egtvedt , Dirk Brandewie , Randy Dunlap , linux-doc@vger.kernel.org, Linux Kernel Mailing List , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" Subject: Re: [PATCH 00/20] Introduce new cpufreq helper macros References: <534C4E14.3080509@semaphore.gr> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2014 09:01 πμ, Viresh Kumar wrote: > On 15 April 2014 02:37, Stratos Karafotis wrote: >> This patch set introduces two freq_table helper macros which >> can be used for iteration over cpufreq_frequency_table and >> makes the necessary changes to cpufreq core and drivers that >> use such an iteration procedure. >> >> The motivation was a usage of common procedure to iterate over >> cpufreq_frequency_table across all drivers and cpufreq core. >> >> This was tested on a x86_64 platform. >> Patches 4-17 compiled successfully but unfortunately I was not >> able to compile test patches 18-20. > > Mostly okay, just some Nitpicks.. > > Please rearrange your patches this way: > - First patch just adds the wrappers > - Second one makes changes to drivers/cpufreq/, i.e. include all core > and drivers > changes into a single patch here as the logs are exactly same. > - Then framework by framework, as we may need Acks/Reviews by them > separately.. > > So, probably just 5-7 would do. > Thanks for your review and your corrections! I will prepare and send the v2 according to your suggestions. Stratos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/