From: Neil Zhang <zhangwm@marvell.com>
To: Will Deacon <will.deacon@arm.com>
CC: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sudeep Holla <Sudeep.Holla@arm.com>
Date: Tue, 15 Apr 2014 05:37:17 -0700
Subject: RE: [PATCH v2] ARM: perf: save/restore pmu registers in pm notifier
Thread-Topic: [PATCH v2] ARM: perf: save/restore pmu registers in pm notifier
Thread-Index: Ac9Yh21art0x/TvoSBiDNoPfiamkyQAH3EDg
Message-ID: <175CCF5F49938B4D99B2E3EF7F558EBE55075F1873@SC-VEXCH4.marvell.com>
References: <1397439742-28337-1-git-send-email-zhangwm@marvell.com>
 <20140415084749.GG17408@arm.com>
In-Reply-To: <20140415084749.GG17408@arm.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit

Will,
Thanks for the comments!

> -----Original Message-----
> From: Will Deacon [mailto:will.deacon@arm.com]
> Sent: 2014??4??15?? 16:48
> To: Neil Zhang
> Cc: linux@arm.linux.org.uk; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; Sudeep Holla
> Subject: Re: [PATCH v2] ARM: perf: save/restore pmu registers in pm notifier
> 
> Hello,
> 
> On Mon, Apr 14, 2014 at 02:42:22AM +0100, Neil Zhang wrote:
> > From: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
> >
> > This adds core support for saving and restoring CPU PMU registers for
> > suspend/resume support i.e. deeper C-states in cpuidle terms.
> > This patch adds support only to ARMv7 PMU registers save/restore.
> > It needs to be extended to xscale and ARMv6 if needed.
> >
> > [Neil] We found that DS-5 not work on our CA7 based SoCs.
> > After debuging, found PMU registers were lost because of core power down.
> > Then i found Sudeep had a patch to fix it about two years ago but not
> > in the mainline, just port it.
> 
> What I don't like about this patch is that we're introducing significant
> overhead for SoCs that don't require save/restore of the PMU state. I'd much
> rather see core power down disabled whilst the PMU is in use but, if that's not
> possible, then I think we need to:
> 
>  (1) Make this conditional for cores that really need it
> 
>  (2) Only save/restore if the PMU is in use (even better, just save/restore
>      the live registers, but that's probably not worth the effort
>      initially).
> 

The patch has check the ARMV7_PMNC_E bit when save / restore, 
so suppose only the core's that use PMU will do the save / restore work.

>  (3) Ensure we ->reset the PMU before doing the restore

Ok, I can add it in the next version.

> 
> Will

Best Regards,
Neil Zhang

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?