MIME-Version: 1.0
In-Reply-To: <87r44yixds.fsf@gmail.com>
References: <87r44yixds.fsf@gmail.com>
Date: Tue, 15 Apr 2014 09:57:06 -0400
Message-ID: <CADVnQynJD7WtSFUtr=es=XnL2i2nV2dERU_7bNr1n1wJArSVCQ@mail.gmail.com>
Subject: Re: [PATCH v2] ipv4: Add option to get TCP_FASTOPEN to getsockopt()
From: Neal Cardwell <ncardwell@google.com>
To: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Netdev <netdev@vger.kernel.org>,
        Yuchung Cheng <ycheng@google.com>, Eric Dumazet <edumazet@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Apr 15, 2014 at 8:35 AM, Kenjiro Nakayama
<nakayamakenjiro@gmail.com> wrote:
> Hi,

Please omit the "Hi," at the top of the patch description, so the top
of the email can be used directly as a git commit description.

> TCP_FASTOPEN option can be set via setsockopt(), but the value cannot be
> gotten via getsockopt(). This patch adds the option to getsockopt().
>
> Sighned-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>

Typo: this should be "Signed-off-by:"

>         Add option to get TCP_FASTOPEN to getsockopt()

Likewise, please omit the extra descriptive text below the
"Signed-off-by:" footer.

(And, of course, please note Eric's remarks as well...)

thanks,
neal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/