From: Arnd Bergmann <arnd@arndb.de>
To: Anders Berg <anders.berg@lsi.com>
Cc: linux-arm-kernel@lists.infradead.org, olof@lixom.net,
        mturquette@linaro.org, mark.rutland@arm.com, dbaryshkov@gmail.com,
        linus.walleij@linaro.org, linux@arm.linux.org.uk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: Device tree for AXM55xx.
Date: Tue, 15 Apr 2014 17:23:28 +0200
Message-ID: <11327885.Oem0QkHdqf@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20140415152047.GB32285@swsaberg01>
References: <cover.1397552154.git.anders.berg@lsi.com> <8344066.GP0Bf5lvlE@wuerfel> <20140415152047.GB32285@swsaberg01>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org

On Tuesday 15 April 2014 17:20:47 Anders Berg wrote:
> > > +                   gpio0: gpio@2010092000 {
> > > +                           #gpio-cells = <2>;
> > > +                           compatible = "arm,pl061", "arm,primecell";
> > > +                           gpio-controller;
> > > +                           reg = <0x20 0x10092000 0x00 0x1000>;
> > > +                           interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> > > +                                        <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > > +                           clocks = <&clk_per>;
> > > +                           clock-names = "apb_pclk";
> > > +                           status = "disabled";
> > 
> > The pl061 binding does not specify any clocks at all. Do we need to update
> > that?
> 
> Doesn't all AMBA devices need at least one apb_pclk since the bus driver does
> clk_get(...,"apb_pclk") before calling probe()?

Yes, I was mostly wondering whether we had a policy about whether this clock
should also be listed in the binding or not. My feeling is that it's better
to make that explicit.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/