Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754378AbaDPGbk (ORCPT ); Wed, 16 Apr 2014 02:31:40 -0400 Received: from g2t2352.austin.hp.com ([15.217.128.51]:17314 "EHLO g2t2352.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbaDPGbg (ORCPT ); Wed, 16 Apr 2014 02:31:36 -0400 X-Greylist: delayed 103057 seconds by postgrey-1.27 at vger.kernel.org; Wed, 16 Apr 2014 02:31:35 EDT Message-ID: <534E2399.5030801@hp.com> Date: Wed, 16 Apr 2014 14:30:49 +0800 From: "Li, ZhenHua" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: David Miller CC: sathya.perla@emulex.com, subbu.seetharaman@emulex.com, ajit.khaparde@emulex.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet References: <1397544352-28841-1-git-send-email-zhen-hual@hp.com> <20140415.150950.2105729446204659132.davem@davemloft.net> In-Reply-To: <20140415.150950.2105729446204659132.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David, I think you are right. I checked other NIC drivers, found some of them call rtnl_lock and rtnl_unlock around netif_device_detach and attach functions, while some drivers did not. I will create a new patch in generic way to fix this. Regards ZhenHua On 04/16/2014 03:09 AM, David Miller wrote: > From: "Li, Zhen-Hua" > Date: Tue, 15 Apr 2014 14:45:52 +0800 > >> From: "Li, Zhen-Hua" >> >> In benet driver, netif_device_detach and netif_device_attach should be >> called between rtnl_lock and rtnl_unlock. >> >> Signed-off-by: Li, Zhen-Hua > > This absolutely does not look like a driver specific issue, therefore > I do not want you to make such locking context adjustments only in > your driver. > > Do it somewhere generic so that every driver gets the fix, not just > your driver. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/