Message-ID: <1397659190.32088.4.camel@joe-AO722>
Subject: Re: [PATCH] staging : android : uapi : fix coding style
From: Joe Perches <joe@perches.com>
To: Seunghun Lee <waydi1@gmail.com>, John Stultz <john.stultz@linaro.org>
Cc: greg@kroah.com, swetland@google.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Date: Wed, 16 Apr 2014 07:39:50 -0700
In-Reply-To: <1397658459-4357-1-git-send-email-waydi1@gmail.com>
References: <1397658459-4357-1-git-send-email-waydi1@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

(adding John Stultz)

On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote:
> This patch fix checkpatch.pl warnings and errors.
[]
> diff --git a/drivers/staging/android/uapi/binder.h b/drivers/staging/android/uapi/binder.h
[]
> @@ -169,7 +169,7 @@ struct binder_ptr_cookie {
>  struct binder_handle_cookie {
>  	__u32 handle;
>  	binder_uintptr_t cookie;
> -} __attribute__((packed));
> +} __packed;

If this .h file is meant to be a user-space #include,
then it should not use the kernel specific __packed
but keep the __attribute__((packed))

It does use __u32 though and that's generally
kernel specific.

John?  Does any of these binder uapi files need a
bit more sorting out?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/