Message-ID: <3DD0B5DC.BE90D497@mvista.com>
Date: Tue, 12 Nov 2002 00:03:40 -0800
From: george anzinger <george@mvista.com>
Organization: Monta Vista Software
MIME-Version: 1.0
To: "Randy.Dunlap" <rddunlap@osdl.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)
References: <Pine.LNX.4.33L2.0211111539030.23954-100000@dragon.pdx.osdl.net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1381
Lines: 38

"Randy.Dunlap" wrote:
> 
> Hi George,
> 
> I have a couple of small comments on the latest POSIX interface
> patch (take 10 -- NOT HIGH RES).
> 
> 1.  arch/i386/kernel/entry.S uses nr_syscalls and the patch
> removes NR_syscalls from include/asm-i386/sys.h, but
> user-mode-linux needs/uses NR_syscalls.  However, I see why you
> removed it from sys.h:  it's basically a dead file.
> And it looks like include/linux/sys.h shouldn't have that
> #define in it (should be per arch).

The best place for this define, if it is needed at all, is
in unistd.h.  It seems really silly to have to modify so
many files to add a system call.  If it were not so late in
the game, I would offer up a single file system call thing,
but after 260 calls, well, maybe I will even so, but AFTER
the freeze since it will not add any new features.
> 
> 2.  again in arch/i386/kernel/entry.S:  the added syscall number
> /*comments*/ are off by 1.

Oops!  Just a comment though :)
 

-- 
George Anzinger   george@mvista.com
High-res-timers: 
http://sourceforge.net/projects/high-res-timers/
Preemption patch:
http://www.kernel.org/pub/linux/kernel/people/rml
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/