Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756387AbaDPQOH (ORCPT ); Wed, 16 Apr 2014 12:14:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27825 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754398AbaDPQOD (ORCPT ); Wed, 16 Apr 2014 12:14:03 -0400 Subject: Re: [PATCH 2/2] net: Implement SO_PASSCGROUP to enable passing cgroup path From: Simo Sorce To: Andy Lutomirski Cc: David Miller , Vivek Goyal , Tejun Heo , Daniel Walsh , "linux-kernel@vger.kernel.org" , lpoetter@redhat.com, cgroups@vger.kernel.org, kay@redhat.com, Network Development In-Reply-To: References: <20140416002010.GA5035@redhat.com> <20140416.085743.1614257692560892039.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Date: Wed, 16 Apr 2014 12:13:57 -0400 Message-ID: <1397664837.19767.410.camel@willson.li.ssimo.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-04-16 at 07:37 -0700, Andy Lutomirski wrote: > On Wed, Apr 16, 2014 at 5:57 AM, David Miller wrote: > > > > Please, just stop. > > No. > > This thread is proposing an ABI. This means that, if the ABI ends up > in Linus's kernel, then it has to be supported forever. Now is the > time to find and fix any issues with it before they become much harder > to fix. Ok, but so far I haven't seen a single objection from you that has solid grounds. The only one that *may* be reasonable is the "secret" cgroup name one, however nobody seem to come up with a reason why it is legitimate to allow to keep cgroup names secret. And if you can come up with such a good reason the SO_NOPASSCGROUP option seem the right solution. > This ABI is especially tricky because programs will use it even if > they don't explicitly try to. So just adding the ABI may break > existing assumptions that are relevant to security or correctness. It's not clear to me what you mean by this, either you explicitly use SO_PASSCGROUP or not, it's not like you can involuntarily add a flag ... Simo. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/