Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbaDPQyL (ORCPT ); Wed, 16 Apr 2014 12:54:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22461 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbaDPQyH (ORCPT ); Wed, 16 Apr 2014 12:54:07 -0400 Subject: Re: [PATCH 2/2] net: Implement SO_PASSCGROUP to enable passing cgroup path From: Simo Sorce To: Tejun Heo Cc: Andy Lutomirski , David Miller , Vivek Goyal , Daniel Walsh , "linux-kernel@vger.kernel.org" , lpoetter@redhat.com, cgroups@vger.kernel.org, kay@redhat.com, Network Development In-Reply-To: <20140416162149.GI1257@htj.dyndns.org> References: <20140416002010.GA5035@redhat.com> <20140416.085743.1614257692560892039.davem@davemloft.net> <1397664837.19767.410.camel@willson.li.ssimo.org> <20140416162149.GI1257@htj.dyndns.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 16 Apr 2014 12:54:01 -0400 Message-ID: <1397667241.19767.434.camel@willson.li.ssimo.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-04-16 at 12:21 -0400, Tejun Heo wrote: > Hello, > > On Wed, Apr 16, 2014 at 12:13:57PM -0400, Simo Sorce wrote: > > The only one that *may* be reasonable is the "secret" cgroup name one, > > however nobody seem to come up with a reason why it is legitimate to > > allow to keep cgroup names secret. > > Ugh, please don't play security games with cgroup names. It is one of > the identifying properties of a task, like a pid, and will be used in > other parts of the kernel to match groups of tasks. If we play > security peekaboo with cgroup names, it has to be transitive and puts > burdens on all its future uses. Unless there are *REALLY* strong > rationales, which can also justify hiding pids, this isn't happening. FWIW, I totally agree with you, it's Andy Lutomirski that is coming up with this "secret" cgropus name idea, nobody else (so far) seem to agree it makes sense. Simo. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/