Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756514AbaDPUBl (ORCPT ); Wed, 16 Apr 2014 16:01:41 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:45466 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756416AbaDPUBg (ORCPT ); Wed, 16 Apr 2014 16:01:36 -0400 Date: Wed, 16 Apr 2014 16:01:32 -0400 From: Tejun Heo To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 1/2] ahci: Ensure "MSI Revert to Single Message" mode is not enforced Message-ID: <20140416200132.GG22569@htj.dyndns.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Alexander. On Wed, Apr 02, 2014 at 10:19:56AM +0200, Alexander Gordeev wrote: > +static int ahci_is_mrsm(struct ahci_host_priv *hpriv) > +{ > + void __iomem *mmio = hpriv->mmio; > + u32 ctl = readl(mmio + HOST_CTL); > + > + return ctl & HOST_MRSM; > +} Can you please just open code this in ahci_init_interrupt()? Also, do I need to backport this through -stable? Has this been tested somehow? What are the impacts of missing this? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/