Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756823AbaDPVZv (ORCPT ); Wed, 16 Apr 2014 17:25:51 -0400 Received: from mail-vc0-f176.google.com ([209.85.220.176]:54104 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754956AbaDPVZq (ORCPT ); Wed, 16 Apr 2014 17:25:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397592876-5741-1-git-send-email-dianders@chromium.org> <1397672724-9063-1-git-send-email-dianders@chromium.org> <1397672724-9063-6-git-send-email-dianders@chromium.org> Date: Wed, 16 Apr 2014 14:25:45 -0700 X-Google-Sender-Auth: qwk-ruLwB3xhw9t6CgYbYouJovw Message-ID: Subject: Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries From: Doug Anderson To: Simon Glass Cc: Anton Vorontsov , Olof Johansson , Sachin Kamat , AJAY KUMAR RAMAKRISHNA SHYMALAMMA , linux-samsung-soc , Michael Spang , Sean Paul , Liam Girdwood , Mark Brown , lk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simon, On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass wrote: >> +#define MAX_CTRL_READ_TRIES 5 >> +#define MAX_FET_ENABLE_TRIES 1000 > > Gosh that is a lot of tries - should we maybe give up sooner? That's actually a squash of a recent patch. See . I've specifically seen at least one case on my device where it needed 888 retries at bootup! ...on my really old Chromebook, it seems to get into a bad state if it sits on my desk for a long time. After I use it a bit it rarely needs more than 10 retries. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/