Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422694AbaDPX0Q (ORCPT ); Wed, 16 Apr 2014 19:26:16 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:37555 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422652AbaDPX0O (ORCPT ); Wed, 16 Apr 2014 19:26:14 -0400 MIME-Version: 1.0 In-Reply-To: <20140416173837.GO1257@htj.dyndns.org> References: <4114063.RkqNFBsH49@daeseok-laptop.cloud.net> <20140416173837.GO1257@htj.dyndns.org> Date: Thu, 17 Apr 2014 08:26:13 +0900 Message-ID: Subject: Re: [PATCH 2/2] workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's From: DaeSeok Youn To: Tejun Heo Cc: =?UTF-8?B?6LWW5rGf5bGx?= , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ok. I will update the comment in the code and patch description. Thanks for review. Regards, Daeseok Youn. 2014-04-17 2:38 GMT+09:00 Tejun Heo : > Hello, > > On Wed, Apr 16, 2014 at 02:33:27PM +0900, Daeseok Youn wrote: >> >> Replace blocks of code which checks whether pwq is defalut with >> jump to use_dfl_pwq. It is same as before. > > A better wording would be sth like > > wq_update_unbound_numa(), when it's decided that the newly updated > cpumask equals the default, looks at whether the current pwq is > already the default one and skips setting pwq to the default one. > This extra step is unnecessary and we can always jump to use_dfl_pwq > instead. Simplify the code by removing the conditional. This > doesn't make any functional difference. > >> Signed-off-by: Daeseok Youn >> --- >> kernel/workqueue.c | 5 +---- >> 1 files changed, 1 insertions(+), 4 deletions(-) >> >> diff --git a/kernel/workqueue.c b/kernel/workqueue.c >> index 3150b21..0679854 100644 >> --- a/kernel/workqueue.c >> +++ b/kernel/workqueue.c >> @@ -4087,10 +4087,7 @@ static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu, >> if (cpumask_equal(cpumask, pwq->pool->attrs->cpumask)) >> goto out_unlock; >> } else { >> - if (pwq == wq->dfl_pwq) >> - goto out_unlock; >> - else >> - goto use_dfl_pwq; >> + goto use_dfl_pwq; > > As I said before, please update the comment above to match the new > code. > > Thanks. > > -- > tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/