Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756883AbaDQNhO (ORCPT ); Thu, 17 Apr 2014 09:37:14 -0400 Received: from mail-pd0-f169.google.com ([209.85.192.169]:40194 "EHLO mail-pd0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754107AbaDQNhM (ORCPT ); Thu, 17 Apr 2014 09:37:12 -0400 From: Jianyu Zhan To: mmarek@suse.cz, akpm@linux-foundation.org, prarit@redhat.com, michael.opdenacker@free-electrons.com, tkhai@yandex.ru, nasa4836@gmail.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] scripts/tags.sh: add regular expression replacement pattern for memcg Date: Thu, 17 Apr 2014 21:37:02 +0800 Message-Id: <1397741822-28836-1-git-send-email-nasa4836@gmail.com> X-Mailer: git-send-email 1.9.0.GIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Marek. > It does not look like new macros are being defined here on a weekly basis... Hmm, I think so. I've removed this comment. > Please do not interleave the new defines with the > defines. Ok. Here is the renewed patch: --- Currently, no regular expression replacement pattern for PageCgroug* defined, which causes quite a few pain while reading code. Just get rid of it. Signed-off-by: Jianyu Zhan --- scripts/tags.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/tags.sh b/scripts/tags.sh index f2c5b00..7d3ebfe 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -187,6 +187,10 @@ exuberant() --regex-c++='/TESTCLEARFLAG_FALSE\(([^,)]*).*/TestClearPage\1/' \ --regex-c++='/__TESTCLEARFLAG_FALSE\(([^,)]*).*/__TestClearPage\1/' \ --regex-c++='/_PE\(([^,)]*).*/PEVENT_ERRNO__\1/' \ + --regex-c++='/TESTPCGFLAG\(([^,)]*).*/PageCgroup\1/' \ + --regex-c++='/SETPCGFLAG\(([^,)]*).*/SetPageCgroup\1/' \ + --regex-c++='/CLEARPCGFLAG\(([^,)]*).*/ClearPageCgroup\1/' \ + --regex-c++='/TESTCLEARPCGFLAG\(([^,)]*).*/TestClearPageCgroup\1/' \ --regex-c='/PCI_OP_READ\((\w*).*[1-4]\)/pci_bus_read_config_\1/' \ --regex-c='/PCI_OP_WRITE\((\w*).*[1-4]\)/pci_bus_write_config_\1/' \ --regex-c='/DEFINE_(MUTEX|SEMAPHORE|SPINLOCK)\((\w*)/\2/v/' \ @@ -244,6 +248,10 @@ emacs() --regex='/__CLEARPAGEFLAG_NOOP(\([^,)]*\).*/__ClearPage\1/' \ --regex='/TESTCLEARFLAG_FALSE(\([^,)]*\).*/TestClearPage\1/' \ --regex='/__TESTCLEARFLAG_FALSE(\([^,)]*\).*/__TestClearPage\1/' \ + --regex='/TESTPCGFLAG\(([^,)]*).*/PageCgroup\1/' \ + --regex='/SETPCGFLAG\(([^,)]*).*/SetPageCgroup\1/' \ + --regex='/CLEARPCGFLAG\(([^,)]*).*/ClearPageCgroup\1/' \ + --regex='/TESTCLEARPCGFLAG\(([^,)]*).*/TestClearPageCgroup\1/' \ --regex='/_PE(\([^,)]*\).*/PEVENT_ERRNO__\1/' \ --regex='/PCI_OP_READ(\([a-z]*[a-z]\).*[1-4])/pci_bus_read_config_\1/' \ --regex='/PCI_OP_WRITE(\([a-z]*[a-z]\).*[1-4])/pci_bus_write_config_\1/' -- 1.9.0.GIT -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/