Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757048AbaDQNle (ORCPT ); Thu, 17 Apr 2014 09:41:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756553AbaDQNla (ORCPT ); Thu, 17 Apr 2014 09:41:30 -0400 Date: Thu, 17 Apr 2014 09:41:23 -0400 From: Vivek Goyal To: Andy Lutomirski Cc: Simo Sorce , David Miller , Tejun Heo , Daniel Walsh , "linux-kernel@vger.kernel.org" , lpoetter@redhat.com, cgroups@vger.kernel.org, kay@redhat.com, Network Development Subject: Re: [PATCH 2/2] net: Implement SO_PASSCGROUP to enable passing cgroup path Message-ID: <20140417134123.GA15749@redhat.com> References: <1397664837.19767.410.camel@willson.li.ssimo.org> <20140416180642.GG31074@redhat.com> <20140416182530.GB550@redhat.com> <20140416190657.GK31074@redhat.com> <20140416193918.GM31074@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 16, 2014 at 01:24:32PM -0700, Andy Lutomirski wrote: [..] > I'm not talking about the risk that someone learns someone's cgroup. > I'm talking about the risk that a malicious program can get a lot > entry like: "whatever planted text" > _SYSTEMD_UNIT=non-malicious.service. That is, they've spoofed a log > line. > > If you don't care about spoofing of log lines, then there's no point > to having the kernel validate them anyway. What's wrong with this. A message came from a cgroup which maps to a unit xyz and it got logged. I can't see what's wrong here. Anyway that message will get logged with unit information. These patches will just make getting unit information race free and more reliable. Thansk Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/