Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbaDQO1P (ORCPT ); Thu, 17 Apr 2014 10:27:15 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:47079 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbaDQO1I (ORCPT ); Thu, 17 Apr 2014 10:27:08 -0400 MIME-Version: 1.0 In-Reply-To: References: <1396510519-8555-1-git-send-email-sbhatta@xilinx.com> <113d0620-4003-417d-806b-0b79ae692829@VA3EHSMHS023.ehs.local> <20140403145853.GD14162@saruman.home> Date: Thu, 17 Apr 2014 19:57:06 +0530 Message-ID: Subject: Re: [PATCH v2 2/2] usb: gadget: Add xilinx axi usb2 device support From: sundeep subbaraya To: Paul Zimmerman Cc: "balbi@ti.com" , Subbaraya Sundeep Bhatta , Greg Kroah-Hartman , Michal Simek , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Subbaraya Sundeep Bhatta Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Apr 17, 2014 at 1:38 AM, Paul Zimmerman wrote: >> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-owner@vger.kernel.org] On Behalf Of sundeep subbaraya >> Sent: Wednesday, April 16, 2014 3:39 AM >> >> Hi Felipe, >> >> On Thu, Apr 3, 2014 at 8:28 PM, Felipe Balbi wrote: >> >> >> +static int start_dma(struct xusb_ep *ep, u32 src, u32 dst, u32 length) >> > >> > please prepend this with xudc_, it makes tracing a lot easier. >> > >> >> +{ >> >> + struct xusb_udc *udc; >> >> + int rc = 0; >> >> + unsigned long timeout; >> >> + >> >> + udc = ep->udc; >> >> + /* >> >> + * Set the addresses in the DMA source and >> >> + * destination registers and then set the length >> >> + * into the DMA length register. >> >> + */ >> >> + udc->write_fn(udc->base_address, XUSB_DMA_DSAR_ADDR_OFFSET, src); >> >> + udc->write_fn(udc->base_address, XUSB_DMA_DDAR_ADDR_OFFSET, dst); >> >> + udc->write_fn(udc->base_address, XUSB_DMA_LENGTH_OFFSET, length); >> >> + >> >> + /* >> >> + * Wait till DMA transaction is complete and >> >> + * check whether the DMA transaction was >> >> + * successful. >> >> + */ >> >> + while ((udc->read_fn(ep->udc->base_address + XUSB_DMA_STATUS_OFFSET) & >> >> + XUSB_DMA_DMASR_BUSY) == XUSB_DMA_DMASR_BUSY) { >> >> + timeout = jiffies + 10000; >> >> + >> >> + if (time_after(jiffies, timeout)) { >> >> + rc = -ETIMEDOUT; >> >> + goto clean; >> >> + } >> >> + } >> > >> > don't you get an IRQ for DMA completion ? If you do, you could be using >> > wait_for_completion() >> >> This function is called in interrupt context when buffer is ready or >> free. It initiates >> DMA to transfer data from IP buffer to memory. Hence it waits in busy >> loop till DMA >> completes > > If this function is called in interrupt context, then you can't use > jiffies for your timeout, since jiffies may not get updated while in > interrupt context. Yes. It is obvious that this logic is buggy, will change this. Thanks, Sundeep.B.S. > > -- > Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/