Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751882AbaDRIav (ORCPT ); Fri, 18 Apr 2014 04:30:51 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:39497 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750974AbaDRIa1 (ORCPT ); Fri, 18 Apr 2014 04:30:27 -0400 Date: Fri, 18 Apr 2014 09:29:36 +0100 From: Russell King - ARM Linux To: Alex Elder Cc: bcm@fixthebug.org, mporter@linaro.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/10] ARM: bcm: tidy up a few includes Message-ID: <20140418082936.GA24070@n2100.arm.linux.org.uk> References: <1397788215-20279-1-git-send-email-elder@linaro.org> <1397788215-20279-8-git-send-email-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397788215-20279-8-git-send-email-elder@linaro.org> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 17, 2014 at 09:30:12PM -0500, Alex Elder wrote: > Clean up a few header file includes, eliminating a few that are not > really needed and putting in their place some that are. > > Signed-off-by: Alex Elder > Reviewed-by: Matt Porter > --- > arch/arm/mach-bcm/board_bcm21664.c | 3 +-- > arch/arm/mach-bcm/kona.c | 5 +++-- > arch/arm/mach-bcm/kona.h | 1 + > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-bcm/board_bcm21664.c b/arch/arm/mach-bcm/board_bcm21664.c > index acc1573..ab96c3f 100644 > --- a/arch/arm/mach-bcm/board_bcm21664.c > +++ b/arch/arm/mach-bcm/board_bcm21664.c > @@ -11,13 +11,12 @@ > * GNU General Public License for more details. > */ > > -#include > #include > #include > > #include > +#include It's linux/io.h > diff --git a/arch/arm/mach-bcm/kona.h b/arch/arm/mach-bcm/kona.h > index 110185f..bcdcf06 100644 > --- a/arch/arm/mach-bcm/kona.h > +++ b/arch/arm/mach-bcm/kona.h > @@ -12,6 +12,7 @@ > */ > > #ifdef CONFIG_ARCH_BCM_MOBILE_L2_CACHE > +#include > > void __init kona_l2_cache_init(void); Just get rid of the __init instead. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/