Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbaDRMts (ORCPT ); Fri, 18 Apr 2014 08:49:48 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:14122 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807AbaDRMtl (ORCPT ); Fri, 18 Apr 2014 08:49:41 -0400 Message-ID: <53511F60.3040301@atmel.com> Date: Fri, 18 Apr 2014 14:49:36 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Boris BREZILLON , Mike Turquette , Alexandre Belloni , Jean-Jacques Hiblot , Jean-Christophe PLAGNIOL-VILLARD CC: , , , , "Boris BREZILLON" Subject: Re: [PATCH v2 02/11] clk: at91: update main clk documentation References: <1395649643-9146-1-git-send-email-b.brezillon.dev@gmail.com> <1395649643-9146-3-git-send-email-b.brezillon.dev@gmail.com> In-Reply-To: <1395649643-9146-3-git-send-email-b.brezillon.dev@gmail.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2014 09:27, Boris BREZILLON : > Update main clk documentation to match main clk implementation rework. > > Signed-off-by: Boris BREZILLON > --- > .../devicetree/bindings/clock/at91-clock.txt | 56 ++++++++++++++++---- > 1 file changed, 47 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/at91-clock.txt b/Documentation/devicetree/bindings/clock/at91-clock.txt > index cd5e239..9a7025b 100644 > --- a/Documentation/devicetree/bindings/clock/at91-clock.txt > +++ b/Documentation/devicetree/bindings/clock/at91-clock.txt > @@ -15,8 +15,13 @@ Required properties: > All at91 specific clocks (clocks defined below) must be child > node of the PMC node. > > + "atmel,at91rm9200-clk-main-osc" > + "atmel,at91sam9x5-clk-main-rc-osc" > + at91 main clk sources > + > + "atmel,at91sam9x5-clk-main" > "atmel,at91rm9200-clk-main": > - at91 main oscillator > + at91 main clock > > "atmel,at91rm9200-clk-master" or > "atmel,at91sam9x5-clk-master": > @@ -85,24 +90,57 @@ For example: > /* put at91 clocks here */ > }; > > +Required properties for main clock oscillator: > +- interrupt-parent : must reference the PMC node. > +- interrupts : shall be set to "<0>". > +- clock-frequency : define the internal RC oscillator frequency. > + > +Optional properties: > +- clock-accuracy : define the internal RC oscillator accuracy. > + > +For example: > + main_rc_osc: main_rc_osc { > + compatible = "atmel,at91sam9x5-clk-main-rc-osc"; > + interrupt-parent = <&pmc>; > + interrupts = <0>; > + clock-frequency = <12000000>; > + clock-accuracy = <50000000>; > + }; Don't you swapped this example above with the description below? > +Required properties for main clock internal RC oscillator: > +- interrupt-parent : must reference the PMC node. > +- interrupts : shall be set to "<0>". > +- #clock-cells : from common clock binding; shall be set to 0. > +- clocks : shall encode the main osc source clk sources (see atmel datasheet). > + > +Optional properties: > +- atmel,osc-bypass : boolean property. Specified if a clock signal is provided > + on XIN. > + > + clock signal is directly provided on XIN pin. > + > +For example: > + main_osc: main_osc { > + compatible = "atmel,at91rm9200-clk-main-osc"; > + interrupt-parent = <&pmc>; > + interrupts = <0>; > + #clock-cells = <0>; > + clocks = <&main_xtal>; > + }; > + > Required properties for main clock: > - interrupt-parent : must reference the PMC node. > - interrupts : shall be set to "<0>". > - #clock-cells : from common clock binding; shall be set to 0. > -- clocks (optional if clock-frequency is provided) : shall be the slow clock > - phandle. This clock is used to calculate the main clock rate if > - "clock-frequency" is not provided. > -- clock-frequency : the main oscillator frequency.Prefer the use of > - "clock-frequency" over automatic clock rate calculation. > +- clocks : shall encode the main clk sources (see atmel datasheet). > > For example: > main: mainck { > - compatible = "atmel,at91rm9200-clk-main"; > + compatible = "atmel,at91sam9x5-clk-main"; > interrupt-parent = <&pmc>; > interrupts = <0>; > #clock-cells = <0>; > - clocks = <&ck32k>; > - clock-frequency = <18432000>; > + clocks = <&main_rc_osc &main_osc>; > }; > > Required properties for master clock: > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/