MIME-Version: 1.0
In-Reply-To: <5350257A.30107@web.de>
References: <1397749778-14485-1-git-send-email-tom.leiming@gmail.com>
	<1397749778-14485-4-git-send-email-tom.leiming@gmail.com>
	<5350257A.30107@web.de>
Date: Fri, 18 Apr 2014 23:47:51 +0800
Message-ID: <CACVXFVMFuiHpM-bVjyutP7fH621Gt0bo2+HLwRbk_aGsiZ+1Vw@mail.gmail.com>
Subject: Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()
From: Ming Lei <tom.leiming@gmail.com>
To: =?UTF-8?B?SsO2cmctVm9sa2VyIFBlZXR6?= <jvpeetz@web.de>
Cc: Jens Axboe <axboe@kernel.dk>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org

On Fri, Apr 18, 2014 at 3:03 AM, Jörg-Volker Peetz <jvpeetz@web.de> wrote:
> Ming Lei wrote, on 04/17/2014 17:49:
>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>> ---
>>  block/blk-mq.c |    7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/block/blk-mq.c b/block/blk-mq.c
>> index baff2d0..1eff3d9 100644
>> --- a/block/blk-mq.c
>> +++ b/block/blk-mq.c
>> @@ -1130,12 +1130,7 @@ static void blk_mq_free_rq_map(struct blk_mq_tag_set *set,
>>
>>  static size_t order_to_size(unsigned int order)
>>  {
>> -     size_t ret = PAGE_SIZE;
>> -
>> -     while (order--)
>> -             ret *= 2;
>> -
>> -     return ret;
>> +     return (1 << order) * PAGE_SIZE;
>
> Shouldn't this be
>
>         return ((size_t)1 << order) * PAGE_SIZE;
>
> ?

IMO, it isn't necessary since compiler will cast type
of 1 and the expression to size_t automatically.


Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/