Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754394AbaDRRwR (ORCPT ); Fri, 18 Apr 2014 13:52:17 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:54130 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbaDRRwP (ORCPT ); Fri, 18 Apr 2014 13:52:15 -0400 Message-ID: <53516650.3000405@cogentembedded.com> Date: Fri, 18 Apr 2014 21:52:16 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Grygorii Strashko , Florian Fainelli , netdev@vger.kernel.org CC: Randy Dunlap , Jonathan Cameron , "David S. Miller" , prabhakar.csengg@gmail.com, santosh.shilimkar@ti.com, Sekhar Nori , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH v2 1/4] mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free References: <1397841897-9170-1-git-send-email-grygorii.strashko@ti.com> <1397841897-9170-2-git-send-email-grygorii.strashko@ti.com> In-Reply-To: <1397841897-9170-2-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/18/2014 09:24 PM, Grygorii Strashko wrote: > Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free() > to automatically clean up MDIO bus alocations made by MDIO drivers, > thus leading to simplified MDIO drivers code. > Cc: Florian Fainelli > Signed-off-by: Grygorii Strashko [...] > index 76f54b3..6412beb 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -69,6 +69,74 @@ struct mii_bus *mdiobus_alloc_size(size_t size) [...] > +/** > + * devm_mdiobus_alloc - Resource-managed mdiobus_alloc_size() > + * @dev: Device to allocate mii_bus for > + * @sizeof_priv: Space to allocate for private structure. > + * > + * Managed mdiobus_alloc_size. mii_bus allocated with this function is > + * automatically freed on driver detach. > + * > + * If an mii_bus allocated with this function needs to be freed separately, > + * devm_mdiobus_free() must be used. > + * > + * RETURNS: > + * Pointer to allocated mii_bus on success, NULL on failure. > + */ > +struct mii_bus *devm_mdiobus_alloc(struct device *dev, int sizeof_priv) > +{ > + struct mii_bus **ptr, *bus; > + > + ptr = devres_alloc(_devm_mdiobus_free, sizeof(*ptr), > + GFP_KERNEL); > + if (!ptr) > + return NULL; > + > + /* use raw alloc_dr for kmalloc caller tracing */ > + bus = mdiobus_alloc_size(sizeof_priv); Since the wrapped function is called mdiobus_alloc_size(), not mdiobus_alloc(), perhaps it's better to call the wrapper devm_mdiobus_alloc_size()? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/