Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbaDRUwZ (ORCPT ); Fri, 18 Apr 2014 16:52:25 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:47097 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbaDRUwW (ORCPT ); Fri, 18 Apr 2014 16:52:22 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 99.127.230.128 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18/gnr/Qh3AlXzsDyEVewf3 Date: Fri, 18 Apr 2014 13:52:14 -0700 From: Tony Lindgren To: Rob Herring Cc: Jean-Jacques Hiblot , Grant Likely , "devicetree@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Rob Herring , Gregory Clement , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 2/2] dt: platform driver: Fill the resources before probe and defer if needed Message-ID: <20140418205213.GA21823@atomide.com> References: <20140320161118.B7075C4067A@trevor.secretlab.ca> <1395413185-29763-1-git-send-email-jjhiblot@traphandler.com> <1395413185-29763-3-git-send-email-jjhiblot@traphandler.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Rob Herring [140411 10:33]: > On Fri, Mar 21, 2014 at 9:46 AM, Jean-Jacques Hiblot > wrote: > > The goal of this patch is to allow drivers to be probed even if at the time of > > the DT parsing some of their IRQ ressources are not available yet. > > > > In the current situation, the IRQ resources of a platform device are filled from > > the DT at the time the device is created (of_device_alloc()). The drawback of > > this is that a device sitting close to the top of the DT (ahb for example) but > > depending on ressources that are initialized later (IRQ domain dynamically > > created for example) will fail to probe because the ressources don't exist > > at this time. > > s/ressources/resources/ While I've tested these two patches and they fix the issue for me. I have some serious doubts again about this whole ------ up string parsing pile of ---- called device tree. Do we really need to sprinkle more of_* hacks to the irq subsystem? There's nothing wrong with with the irq subsystem. Platform bus is just calling the irq subsystem at the wrong time with uninitialized data. It seems that we're again papering over the fact that there's nothing coordinating the setting up of various resources with device tree. That seems to be the repeating never ending pattern as we've already seen with GPIOs, pinctrl, and IRQchips. We end up adding all kinds of cross subsystem calls that were never needed earlier. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/