Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbaDRVXk (ORCPT ); Fri, 18 Apr 2014 17:23:40 -0400 Received: from mail-oa0-f42.google.com ([209.85.219.42]:39292 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753808AbaDRVXe (ORCPT ); Fri, 18 Apr 2014 17:23:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397172708-19735-1-git-send-email-tim.kryger@linaro.org> Date: Fri, 18 Apr 2014 14:23:34 -0700 Message-ID: Subject: Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc From: Tim Kryger To: Ulf Hansson Cc: Chris Ball , Linux MMC Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson wrote: > On 15 April 2014 19:09, Tim Kryger wrote: >> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: >>> A few times I have suggested to switch to use the >>> mmc_regulator_get_supply() API to simplify and consolidate code. Could >>> you please have a look at that? >> >> This function will solve my problem but it also suggests that SDHCI >> drivers should use the vmmc/vqmmc pointers in the mmc_host struct >> rather than the ones in the sdhci_host struct. >> >> Is this your intent? Do you want to see the regulator pointers in the >> sdhci_host struct removed once all drivers are modified to use the >> mmc_host ones? > > Correct. That will consolidate code! > > Then if sdhci has some special needs for regulators, let's first see > if we can adopt the API to handle it, before we decide to put that > code in sdhci driver. Sounds good. Please forget about this patch and consider the new series instead. https://lkml.org/lkml/2014/4/17/653 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/