Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754736AbaDSAth (ORCPT ); Fri, 18 Apr 2014 20:49:37 -0400 Received: from mail-ve0-f181.google.com ([209.85.128.181]:35169 "EHLO mail-ve0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754234AbaDSAte (ORCPT ); Fri, 18 Apr 2014 20:49:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397719309-2022-1-git-send-email-computersforpeace@gmail.com> <1397719309-2022-4-git-send-email-computersforpeace@gmail.com> Date: Fri, 18 Apr 2014 17:49:33 -0700 Message-ID: Subject: Re: [PATCH 3/5] mips: defconfigs: add MTD_SPI_NOR (new dependency for M25P80) From: Brian Norris To: Florian Fainelli Cc: Linux Kernel , Marek Vasut , "linux-mtd@lists.infradead.org" , Ralf Baechle , Linux-MIPS Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 18, 2014 at 5:24 PM, Florian Fainelli wrote: > 2014-04-17 0:21 GMT-07:00 Brian Norris : >> These defconfigs contain the CONFIG_M25P80 symbol, which is now >> dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to the >> relevant defconfigs. > > so CONFIG_M25P80 should select CONFIG_MTD_SPI_NOR, right? in that > case, I do not think this is needed at all, as it would be > automatically picked up during the build and if someone refreshes the > defconfigs, although it cannot hurt. Can you reply to the cover letter? 3 people have made the same comment, and I had a rebuttal that I'm not sure if anyone considered yet. (And it wouldn't be picked up by 'savedefconfig', since it saves a minimal .config; when one symbol 'select's another, the latter is not needed in the defconfig) Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/