Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbaDSIcS (ORCPT ); Sat, 19 Apr 2014 04:32:18 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:64768 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbaDSI1u (ORCPT ); Sat, 19 Apr 2014 04:27:50 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397843871-10850-1-git-send-email-prtvar.b@gmail.com> <20140418232315.GA23165@kroah.com> Date: Sat, 19 Apr 2014 10:27:50 +0200 Message-ID: Subject: Re: [PATCH] Staging: crystalhd: Mark local functions as static From: bojan prtvar To: Greg KH Cc: nsankar@broadcom.com, jarod@wilsonet.com, Scott Davilla , Manu Abraham , Amarjargal G , Dan Carpenter , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar wrote: > On Sat, Apr 19, 2014 at 1:23 AM, Greg KH wrote: >> On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: >>> This fixes the following sparse warnings: >>> drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should it be static? >>> drivers/staging/crystalhd/crystalhd_lnx.c:665:5: warning: symbol 'chd_dec_pci_resume' was not declared. Should it be static? >>> drivers/staging/crystalhd/crystalhd_lnx.c:78:29: warning: symbol 'chd_dec_alloc_iodata' was not declared. Should it be static? >>> drivers/staging/crystalhd/crystalhd_lnx.c:99:6: warning: symbol 'chd_dec_free_iodata' was not declared. Should it be static? >>> >>> Signed-off-by: Bojan Prtvar >>> --- >>> drivers/staging/crystalhd/crystalhd_lnx.c | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> This patch doesn't apply to my tree, can you redo it and resend? >> >> thanks, >> >> greg k-h > > I cloned your tree > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > and on master branch I see work is already done in > > commit 038d3f882926bf49562e5f119957fd81015a9390 > Author: Valentina Manea > Date: Mon Oct 7 23:12:14 2013 +0300 > > Now what confuses me is the date of this patch. Why I didn't see it > linux-next and even in vanilla? > I know this question goes under 'basic workflow section'. > > Regards, > Bojan I re-checked. Everything is OK with 038d3f8829. I made a mess in my local branches. Drop this one. And sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/