Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 12 Nov 2002 16:52:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 12 Nov 2002 16:52:11 -0500 Received: from e31.co.us.ibm.com ([32.97.110.129]:40873 "EHLO e31.co.us.ibm.com") by vger.kernel.org with ESMTP id ; Tue, 12 Nov 2002 16:51:59 -0500 Subject: [PATCH] linux-2.5.47_timer-tsc-cleanup_A0.patch From: john stultz To: Linus Torvalds Cc: lkml Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 Date: 12 Nov 2002 13:54:36 -0800 Message-Id: <1037138077.28539.21.camel@cog> Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2068 Lines: 67 Linus, all Just a resend of my timer_tsc cleanup. This yanks an unused variable and pulls fast_gettimeoffset_quotient from the global namespace. Please apply. thanks, -john diff -Nru a/arch/i386/kernel/smpboot.c b/arch/i386/kernel/smpboot.c --- a/arch/i386/kernel/smpboot.c Tue Nov 12 13:50:47 2002 +++ b/arch/i386/kernel/smpboot.c Tue Nov 12 13:50:47 2002 @@ -181,8 +181,6 @@ #define NR_LOOPS 5 -extern unsigned long fast_gettimeoffset_quotient; - /* * accurate 64-bit/32-bit division, expanded to 32-bit divisions and 64-bit * multiplication. Not terribly optimized but we need it at boot time only @@ -222,7 +220,8 @@ printk("checking TSC synchronization across %u CPUs: ", num_booting_cpus()); - one_usec = ((1<<30)/fast_gettimeoffset_quotient)*(1<<2); + /* convert from kcyc/sec to cyc/usec */ + one_usec = cpu_khz / 1000; atomic_set(&tsc_start_flag, 1); wmb(); diff -Nru a/arch/i386/kernel/timers/timer_tsc.c b/arch/i386/kernel/timers/timer_tsc.c --- a/arch/i386/kernel/timers/timer_tsc.c Tue Nov 12 13:50:47 2002 +++ b/arch/i386/kernel/timers/timer_tsc.c Tue Nov 12 13:50:47 2002 @@ -15,7 +15,6 @@ extern int x86_udelay_tsc; extern spinlock_t i8253_lock; -static int use_tsc; /* Number of usecs that the last interrupt was delayed */ static int delay_at_last_interrupt; @@ -26,7 +25,7 @@ * Equal to 2^32 * (1 / (clocks per usec) ). * Initialized in time_init. */ -unsigned long fast_gettimeoffset_quotient; +static unsigned long fast_gettimeoffset_quotient; static unsigned long get_offset_tsc(void) { @@ -260,7 +259,6 @@ unsigned long tsc_quotient = calibrate_tsc(); if (tsc_quotient) { fast_gettimeoffset_quotient = tsc_quotient; - use_tsc = 1; /* * We could be more selective here I suspect * and just enable this for the next intel chips ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/