Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523AbaDUD2e (ORCPT ); Sun, 20 Apr 2014 23:28:34 -0400 Received: from mail-bn1blp0185.outbound.protection.outlook.com ([207.46.163.185]:43678 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751305AbaDUD2c (ORCPT ); Sun, 20 Apr 2014 23:28:32 -0400 Date: Mon, 21 Apr 2014 10:32:11 +0800 From: Huang Shijie To: Brian Norris CC: Linux Kernel , Marek Vasut , Russell King , Stephen Warren , Thierry Reding , , , Sascha Hauer , Olof Johansson , Shawn Guo Subject: Re: [PATCH 1/5] ARM: defconfigs: add MTD_SPI_NOR (new dependency for M25P80) Message-ID: <20140421023208.GA5268@localhost> References: <1397719309-2022-1-git-send-email-computersforpeace@gmail.com> <1397719309-2022-2-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1397719309-2022-2-git-send-email-computersforpeace@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.246;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009001)(6009001)(428001)(24454002)(189002)(199002)(51704005)(80976001)(74662001)(31966008)(74502001)(77982001)(57986002)(20776003)(79102001)(47776003)(99396002)(6806004)(19580395003)(83506001)(44976005)(19580405001)(83322001)(81542001)(33656001)(46102001)(46406003)(1411001)(81342001)(54356999)(23726002)(76176999)(87936001)(80022001)(33716001)(92726001)(77096999)(50986999)(92566001)(76482001)(97756001)(4396001)(85852003)(83072002)(42262001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB345;H:az84smr01.freescale.net;FPR:5352E8DF.2B2483C1.76F2E1D7.66E43AEF.20555;MLV:sfv;PTR:gate-az5.freescale.com;MX:1;A:1;LANG:; X-Forefront-PRVS: 0188D66E61 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 17, 2014 at 12:21:45AM -0700, Brian Norris wrote: > These defconfigs contain the CONFIG_M25P80 symbol, which is now > dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to the > relevant defconfigs. > > At the same time, drop the now-nonexistent CONFIG_MTD_CHAR symbol. > > Signed-off-by: Brian Norris > Cc: Russell King > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Stephen Warren > Cc: Thierry Reding > Cc: Olof Johansson > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > This change is based on l2-mtd.git/spinor, which is based on 3.15-rc1: > > git://git.infradead.org/l2-mtd.git +spinor > > arch/arm/configs/bockw_defconfig | 2 +- > arch/arm/configs/dove_defconfig | 2 +- > arch/arm/configs/imx_v6_v7_defconfig | 1 + > arch/arm/configs/keystone_defconfig | 1 + > arch/arm/configs/kirkwood_defconfig | 1 + > arch/arm/configs/koelsch_defconfig | 1 + > arch/arm/configs/lager_defconfig | 1 + > arch/arm/configs/lpc32xx_defconfig | 2 +- > arch/arm/configs/multi_v5_defconfig | 1 + > arch/arm/configs/multi_v7_defconfig | 1 + > arch/arm/configs/mvebu_v5_defconfig | 1 + > arch/arm/configs/mvebu_v7_defconfig | 1 + > arch/arm/configs/mxs_defconfig | 1 + > arch/arm/configs/sama5_defconfig | 2 +- > arch/arm/configs/shmobile_defconfig | 1 + > arch/arm/configs/tegra_defconfig | 1 + > 16 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/configs/bockw_defconfig b/arch/arm/configs/bockw_defconfig > index e816140d81c5..28339e072a71 100644 > --- a/arch/arm/configs/bockw_defconfig > +++ b/arch/arm/configs/bockw_defconfig > @@ -50,11 +50,11 @@ CONFIG_DEVTMPFS_MOUNT=y > # CONFIG_PREVENT_FIRMWARE_BUILD is not set > # CONFIG_FW_LOADER is not set > CONFIG_MTD=y > -CONFIG_MTD_CHAR=y > CONFIG_MTD_BLOCK=y > CONFIG_MTD_CFI=y > CONFIG_MTD_CFI_AMDSTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_SCSI=y > CONFIG_BLK_DEV_SD=y > CONFIG_NETDEVICES=y > diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig > index f15955144175..701677f9248c 100644 > --- a/arch/arm/configs/dove_defconfig > +++ b/arch/arm/configs/dove_defconfig > @@ -37,7 +37,6 @@ CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_MTD=y > CONFIG_MTD_CMDLINE_PARTS=y > -CONFIG_MTD_CHAR=y > CONFIG_MTD_BLOCK=y > CONFIG_MTD_CFI=y > CONFIG_MTD_JEDECPROBE=y > @@ -48,6 +47,7 @@ CONFIG_MTD_CFI_INTELEXT=y > CONFIG_MTD_CFI_STAA=y > CONFIG_MTD_PHYSMAP=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > CONFIG_BLK_DEV_RAM_COUNT=1 > diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig > index 09e974392fa1..c098195e9bd3 100644 > --- a/arch/arm/configs/imx_v6_v7_defconfig > +++ b/arch/arm/configs/imx_v6_v7_defconfig > @@ -89,6 +89,7 @@ CONFIG_MTD_SST25L=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_GPMI_NAND=y > CONFIG_MTD_NAND_MXC=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_UBI=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_RAM=y > diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig > index ec9a41d50680..b3057730689f 100644 > --- a/arch/arm/configs/keystone_defconfig > +++ b/arch/arm/configs/keystone_defconfig > @@ -112,6 +112,7 @@ CONFIG_MTD_PLATRAM=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_DAVINCI=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_UBI=y > CONFIG_PROC_DEVICETREE=y > CONFIG_BLK_DEV_LOOP=y > diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig > index 2e762d94e94b..b9e480c10b10 100644 > --- a/arch/arm/configs/kirkwood_defconfig > +++ b/arch/arm/configs/kirkwood_defconfig > @@ -61,6 +61,7 @@ CONFIG_MTD_PHYSMAP=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_ORION=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_EEPROM_AT24=y > # CONFIG_SCSI_PROC_FS is not set > diff --git a/arch/arm/configs/koelsch_defconfig b/arch/arm/configs/koelsch_defconfig > index 86faab565a96..dcd55f20d36e 100644 > --- a/arch/arm/configs/koelsch_defconfig > +++ b/arch/arm/configs/koelsch_defconfig > @@ -42,6 +42,7 @@ CONFIG_ATA=y > CONFIG_SATA_RCAR=y > CONFIG_MTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_NETDEVICES=y > # CONFIG_NET_VENDOR_ARC is not set > # CONFIG_NET_CADENCE is not set > diff --git a/arch/arm/configs/lager_defconfig b/arch/arm/configs/lager_defconfig > index 58702440472a..c4dbd778458b 100644 > --- a/arch/arm/configs/lager_defconfig > +++ b/arch/arm/configs/lager_defconfig > @@ -53,6 +53,7 @@ CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_MTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_SD=y > CONFIG_ATA=y > CONFIG_SATA_RCAR=y > diff --git a/arch/arm/configs/lpc32xx_defconfig b/arch/arm/configs/lpc32xx_defconfig > index 398a367ffce8..2de54c35fb47 100644 > --- a/arch/arm/configs/lpc32xx_defconfig > +++ b/arch/arm/configs/lpc32xx_defconfig > @@ -53,12 +53,12 @@ CONFIG_DEVTMPFS_MOUNT=y > # CONFIG_FW_LOADER is not set > CONFIG_MTD=y > CONFIG_MTD_CMDLINE_PARTS=y > -CONFIG_MTD_CHAR=y > CONFIG_MTD_BLOCK=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_SLC_LPC32XX=y > CONFIG_MTD_NAND_MLC_LPC32XX=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_BLK_DEV_CRYPTOLOOP=y > CONFIG_BLK_DEV_RAM=y > diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig > index aa3dfb084fed..aaf23933fb91 100644 > --- a/arch/arm/configs/multi_v5_defconfig > +++ b/arch/arm/configs/multi_v5_defconfig > @@ -56,6 +56,7 @@ CONFIG_MTD_PHYSMAP=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_ORION=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_EEPROM_AT24=y > # CONFIG_SCSI_PROC_FS is not set > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index d4e8a47a2f7c..9937db16050c 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -108,6 +108,7 @@ CONFIG_CMA_SIZE_MBYTES=64 > CONFIG_OMAP_OCP2SCP=y > CONFIG_MTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_ICS932S401=y > CONFIG_APDS9802ALS=y > diff --git a/arch/arm/configs/mvebu_v5_defconfig b/arch/arm/configs/mvebu_v5_defconfig > index 36484a37a1ca..85d20666cef5 100644 > --- a/arch/arm/configs/mvebu_v5_defconfig > +++ b/arch/arm/configs/mvebu_v5_defconfig > @@ -50,6 +50,7 @@ CONFIG_MTD_PHYSMAP=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_ORION=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_EEPROM_AT24=y > # CONFIG_SCSI_PROC_FS is not set > diff --git a/arch/arm/configs/mvebu_v7_defconfig b/arch/arm/configs/mvebu_v7_defconfig > index a34713d8db9f..ae45bf05fa00 100644 > --- a/arch/arm/configs/mvebu_v7_defconfig > +++ b/arch/arm/configs/mvebu_v7_defconfig > @@ -53,6 +53,7 @@ CONFIG_I2C_MV64XXX=y > CONFIG_MTD=y > CONFIG_MTD_CHAR=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_CFI=y > CONFIG_MTD_CFI_INTELEXT=y > CONFIG_MTD_CFI_AMDSTD=y > diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig > index 6150108e15de..eac87f4fae07 100644 > --- a/arch/arm/configs/mxs_defconfig > +++ b/arch/arm/configs/mxs_defconfig > @@ -55,6 +55,7 @@ CONFIG_MTD_M25P80=y > CONFIG_MTD_SST25L=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_GPMI_NAND=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_UBI=y > # CONFIG_BLK_DEV is not set > CONFIG_EEPROM_AT24=y > diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig > index dc3881e07630..8282ebab6e52 100644 > --- a/arch/arm/configs/sama5_defconfig > +++ b/arch/arm/configs/sama5_defconfig > @@ -65,12 +65,12 @@ CONFIG_DEVTMPFS_MOUNT=y > # CONFIG_PREVENT_FIRMWARE_BUILD is not set > CONFIG_MTD=y > CONFIG_MTD_CMDLINE_PARTS=y > -CONFIG_MTD_CHAR=y > CONFIG_MTD_BLOCK=y > CONFIG_MTD_CFI=y > CONFIG_MTD_M25P80=y > CONFIG_MTD_NAND=y > CONFIG_MTD_NAND_ATMEL=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_UBI=y > CONFIG_MTD_UBI_GLUEBI=y > CONFIG_PROC_DEVICETREE=y > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig > index 83b07258a385..ddfdc36be9c8 100644 > --- a/arch/arm/configs/shmobile_defconfig > +++ b/arch/arm/configs/shmobile_defconfig > @@ -43,6 +43,7 @@ CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_MTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_BLK_DEV_SD=y > CONFIG_ATA=y > CONFIG_SATA_RCAR=y > diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig > index 2926281368ab..e4464986d7b4 100644 > --- a/arch/arm/configs/tegra_defconfig > +++ b/arch/arm/configs/tegra_defconfig > @@ -90,6 +90,7 @@ CONFIG_DMA_CMA=y > CONFIG_CMA_SIZE_MBYTES=64 > CONFIG_MTD=y > CONFIG_MTD_M25P80=y > +CONFIG_MTD_SPI_NOR=y > CONFIG_PROC_DEVICETREE=y > CONFIG_BLK_DEV_LOOP=y > CONFIG_AD525X_DPOT=y > -- I think we should not use the "select", since the SPI-NOR framework also depends on the MTD code. For the mxs_defconfig and imx_v6_v7_defconfig Acked-by: Huang Shijie -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/