Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 12 Nov 2002 19:03:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 12 Nov 2002 19:03:00 -0500 Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:39696 "HELO kroah.com") by vger.kernel.org with SMTP id ; Tue, 12 Nov 2002 19:02:59 -0500 Date: Tue, 12 Nov 2002 16:04:35 -0800 From: Greg KH To: William Lee Irwin III , "Martin J. Bligh" , Matthew Dobson , linux-kernel@vger.kernel.org, hohnbaum@us.ibm.com, mochel@osdl.org Subject: Re: [0/4] NUMA-Q: remove PCI bus number mangling Message-ID: <20021113000435.GE32274@kroah.com> References: <20021112205241.GS23425@holomorphy.com> <3DD172B8.8040802@us.ibm.com> <20021112213504.GV23425@holomorphy.com> <20021112213906.GW23425@holomorphy.com> <177250000.1037141189@flay> <20021112215305.GZ23425@holomorphy.com> <179150000.1037145229@flay> <20021112225937.GA23425@holomorphy.com> <20021112235824.GG22031@holomorphy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021112235824.GG22031@holomorphy.com> User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 31 On Tue, Nov 12, 2002 at 03:58:24PM -0800, William Lee Irwin III wrote: > On Tue, Nov 12, 2002 at 03:53:49PM -0800, Martin J. Bligh wrote: > >> Right, I'm not against the sysdata thing, seems like a much better way > >> to do it in general (what I did was a quick hack). Was just confused > >> by the global bus number assertion, but if we use the sysdata stuff, > >> it's all a non-issue ;-) > > > On Tue, Nov 12, 2002 at 02:59:37PM -0800, William Lee Irwin III wrote: > > Non-issue for merging... > > The pain isn't over yet. =( > > Core PCI code is assuming unique bus numbers in several places. > > Okay, an attempt to remedy this world-breaking braindamage with the > fewest lines of code: > > This alters PCI bus number "clash" detection to compare ->sysdata in > addition to the numbers. The bus number is not a unique identifier. Um, why not? And what would /sys/bus/pci/devices look like if you allow the same identifiers for different devices? :) thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/