Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbaDUQzv (ORCPT ); Mon, 21 Apr 2014 12:55:51 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:54988 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbaDUQzZ convert rfc822-to-8bit (ORCPT ); Mon, 21 Apr 2014 12:55:25 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH 3/4] soc: qcom: Add device tree binding for GSBI From: Kumar Gala In-Reply-To: <1398058244-14099-4-git-send-email-agross@codeaurora.org> Date: Mon, 21 Apr 2014 11:55:20 -0500 Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Santosh Shilimkar , Greg Kroah-Hartman Content-Transfer-Encoding: 8BIT Message-Id: References: <1398058244-14099-1-git-send-email-agross@codeaurora.org> <1398058244-14099-4-git-send-email-agross@codeaurora.org> To: Andy Gross X-Mailer: Apple Mail (2.1874) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Apr 21, 2014, at 12:30 AM, Andy Gross wrote: > Add device tree binding support for the QCOM GSBI driver. > > Signed-off-by: Andy Gross > --- > .../devicetree/bindings/soc/qcom/qcom,gsbi.txt | 78 ++++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt > new file mode 100644 > index 0000000..6462e61 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt > @@ -0,0 +1,78 @@ > +QCOM GSBI (General Serial Bus Interface) Driver > + > +The GSBI controller is modeled as a node with zero or more child nodes, each > +representing a serial sub-node device that is mux'd as part of the GSBI > +configuration settings. The mode setting will govern the input/output mode of > +the 4 GSBI IOs. > + > +Required properties: > +- compatible: must contain "qcom,gsbi-v1.0.0" for APQ8064/IPQ8064 > +- reg: Address range for GSBI registers > +- clocks: required clock > +- clock-names: must contain "iface" entry > +- qcom,mode : indicates MUX value for configuration of the serial interface. > + mode 0: idle, null values applied to all four GSBI IOs > + mode 1: I2C on 2 ports, SIM/R-UIM on other 2. > + mode 2: I2C > + mode 3: SPI > + mode 4: UART w/ flow control > + mode 5: SIM/R-UIM > + mode 6: I2C on 2 ports, UART (without flow control) on other 2 > + mode 7: undefined Can we add defines in a include/dt-bindings for these modes. > + > +Required properties if child node exists: > +- #address-cells: Must be 1 > +- #size-cells: Must be 1 > +- ranges: Must be present > + > +Properties for children: > + > +A GSBI controller node can contain 0 or more child nodes representing serial > +devices. These serial devices can be a QCOM UART, I2C controller, spi > +controller, or some combination of aforementioned devices. > + > +See the following for child node definitions: > +Documentation/devicetree/bindings/i2c/qcom,i2c-qup.txt > +Documentation/devicetree/bindings/spi/qcom,spi-qup.txt > +Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt > + > +Example for APQ8064: > + > + gsbi4@16300000 { > + compatible = "qcom,gsbi-v1.0.0"; > + reg = <0x16300000 0x100>; > + clocks = <&gcc GSBI4_H_CLK>; > + clock-names = "iface"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + qcom,mode = <6>; > + > + /* child nodes go under here */ > + > + i2c_qup4: i2c@16380000 { > + compatible = "qcom,i2c-qup-v1.1.1"; > + reg = <0x16380000 0x1000>; > + interrupts = <0 153 0>; > + > + clocks = <&gcc GSBI4_QUP_CLK>, <&gcc GSBI4_H_CLK>; > + clock-names = "core", "iface"; > + > + clock-frequency = <200000>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + }; > + > + uart4: serial@16340000 { > + compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; > + reg = <0x16340000 0x1000>, > + <0x16300000 0x1000>; > + interrupts = <0 152 0x0>; > + clocks = <&gcc GSBI4_UART_CLK>, <&gcc GSBI4_H_CLK>; > + clock-names = "core", "iface"; > + status = "ok"; > + }; > + }; > + > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/