Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131AbaDURX4 (ORCPT ); Mon, 21 Apr 2014 13:23:56 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:39690 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbaDURXx (ORCPT ); Mon, 21 Apr 2014 13:23:53 -0400 MIME-Version: 1.0 In-Reply-To: References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397824031-4892-13-git-send-email-lftan@altera.com> Date: Tue, 22 Apr 2014 01:23:52 +0800 X-Google-Sender-Auth: WBL2ZJ4_gBBv5HbCIXfDftKa7No Message-ID: Subject: Re: [PATCH 16/28] nios2: System calls handling From: Ley Foon Tan To: Geert Uytterhoeven Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , cltang@codesourcery.com, Pavel Machek Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 20, 2014 at 4:12 AM, Geert Uytterhoeven wrote: >> + */ >> + vma = find_vma(current->mm, addr); >> + if (vma == NULL || addr < vma->vm_start || addr + len > vma->vm_end) >> + return -EFAULT; >> + >> + /* Ignore the scope and cache arguments. */ > > This function doesn't have scope and cache arguments > (sys_cacheflush() on m68k does have them ;-) Missed out the comment after rename the arguments.:) Will update the comment above. > On Sat, Apr 19, 2014 at 6:09 PM, Pavel Machek wrote: >> Also... explanation why you need this syscall while other >> architectures live happily without it would be nice. > > 12 our of 28 architectures provide such a syscall... > > Is flushing the cache a privileged operation on nios2? Yes. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/