Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753566AbaDUSIA (ORCPT ); Mon, 21 Apr 2014 14:08:00 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:58342 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbaDUSH4 (ORCPT ); Mon, 21 Apr 2014 14:07:56 -0400 MIME-Version: 1.0 In-Reply-To: <1398060142-7937-10-git-send-email-acourbot@nvidia.com> References: <1398060142-7937-1-git-send-email-acourbot@nvidia.com> <1398060142-7937-10-git-send-email-acourbot@nvidia.com> Date: Mon, 21 Apr 2014 14:07:56 -0400 X-Google-Sender-Auth: 3RW9SkOU-EuAhMozHZoRLr3vkYQ Message-ID: Subject: Re: [Nouveau] [PATCH v2 09/10] drm/nouveau: support GK20A in nouveau_accel_init() From: Ilia Mirkin To: Alexandre Courbot Cc: Ben Skeggs , "nouveau@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 21, 2014 at 2:02 AM, Alexandre Courbot wrote: > Skip the creation of a software channel for GK20A as software methods > are not yet supported. How is GK20A different from a nvc0+ card that lacks PDISPLAY (like all the 3D Controller ones, and I guess even some that come up as VGA controller in PCI but don't have any outputs in their VBIOS)? i.e. what's wrong with just doing the same thing that GK1xx does? Note that there are sw methods that don't deal with display as well. -ilia > > Signed-off-by: Alexandre Courbot > --- > drivers/gpu/drm/nouveau/nouveau_drm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c > index ddd83756b9a2..5b46148ffd32 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_drm.c > +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c > @@ -208,6 +208,10 @@ nouveau_accel_init(struct nouveau_drm *drm) > return; > } > > + /* Need to figure out how to handle sw for gk20a */ > + if (device->chipset == 0xea) > + goto skip_sw_init; > + > ret = nouveau_object_new(nv_object(drm), NVDRM_CHAN, NVDRM_NVSW, > nouveau_abi16_swclass(drm), NULL, 0, &object); > if (ret == 0) { > @@ -234,6 +238,7 @@ nouveau_accel_init(struct nouveau_drm *drm) > return; > } > > +skip_sw_init: > if (device->card_type < NV_C0) { > ret = nouveau_gpuobj_new(drm->device, NULL, 32, 0, 0, > &drm->notify); > -- > 1.9.2 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/