Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932332AbaDVLTq (ORCPT ); Tue, 22 Apr 2014 07:19:46 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:42046 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932145AbaDVLTm (ORCPT ); Tue, 22 Apr 2014 07:19:42 -0400 Date: Tue, 22 Apr 2014 07:19:06 -0400 From: Neil Horman To: Jianyu Zhan Cc: davem@davemloft.net, lizefan@huawei.com, tj@kernel.org, daniel.wagner@bmw-carit.de, gaofeng@cn.fujitsu.com, stephen@networkplumber.org, jiri@resnulli.us, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netprio_cgroup: explicitly init the early_init field Message-ID: <20140422111906.GD17116@hmsreliant.think-freely.org> References: <1398144722-9864-1-git-send-email-nasa4836@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398144722-9864-1-git-send-email-nasa4836@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 01:32:02PM +0800, Jianyu Zhan wrote: > For a cgroup subsystem who should init early, then it should carefully > take care of the implementation of css_alloc, because it will be called > before mm_init() setup the world. > > Luckily we don't, and we better explicitly assign the early_init field > to 0, for document reason. > > Signed-off-by: Jianyu Zhan > --- > net/core/netprio_cgroup.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c > index 13ddd68..fc21035 100644 > --- a/net/core/netprio_cgroup.c > +++ b/net/core/netprio_cgroup.c > @@ -250,6 +250,7 @@ struct cgroup_subsys net_prio_cgrp_subsys = { > .css_free = cgrp_css_free, > .attach = net_prio_attach, > .base_cftypes = ss_files, > + .early_init = 0, > }; > > static int netprio_device_event(struct notifier_block *unused, > -- > 2.0.0-rc0 > > NACK, for the same reason that it doesn't make sense for net_classid. Early_init should already be zero. What problem are you trying to solve here? Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/