Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbaDVL1h (ORCPT ); Tue, 22 Apr 2014 07:27:37 -0400 Received: from mail-we0-f180.google.com ([74.125.82.180]:61903 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718AbaDVL1g (ORCPT ); Tue, 22 Apr 2014 07:27:36 -0400 Date: Tue, 22 Apr 2014 12:27:17 +0100 From: Lee Jones To: "Rafael J. Wysocki" Cc: Stratos Karafotis , Linus Walleij , Samuel Ortiz , linux-arm-kernel@lists.infradead.org, LKML , Viresh Kumar , "linux-pm@vger.kernel.org" Subject: Re: [PATCH v4 5/8] mfd: db8500-prcmu: Use cpufreq_for_each_entry macro for iteration Message-ID: <20140422112717.GA21613@lee--X1> References: <534DB213.7080802@semaphore.gr> <5355A349.50908@semaphore.gr> <20140422071541.GA17657@lee--X1> <6612075.PRZcWcuj98@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6612075.PRZcWcuj98@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Apr 2014, Rafael J. Wysocki wrote: > On Tuesday, April 22, 2014 08:15:41 AM Lee Jones wrote: > > > The cpufreq core now supports the cpufreq_for_each_entry macro helper > > > for iteration over the cpufreq_frequency_table, so use it. > > > > > > It should have no functional changes. > > > > > Signed-off-by: Stratos Karafotis > > > --- > > > > It would be good to have a changelog which describes the differences > > between the versions, so we can keep track. > > > > > drivers/mfd/db8500-prcmu.c | 19 ++++++++----------- > > > 1 file changed, 8 insertions(+), 11 deletions(-) > > > > So it looks like I already applied v2 of this patch to my tree. What > > changed in v3 and v4? Should I remove that patch from MFD and apply > > this one instead? > > The reason why v4 was sent is because I asked for it. > > And if you applied [5/8] without [1/8], it won't work, because the macro is > introduced by that patch. That's right, which is why I mailed you about it: > > > Applied untested by me. > > > > Wouldn't build. Let it go via Rafael. > > Rafael, would you mind creating a branch from this patch set that we > can both pull from please? > If that's the case, please drop [5/8] and let me handle the entire series. I'm happy for you to apply the series and send me a pull-request for either a) the entire series or b) just the patches which touch MFD and any subsequent decencies. Or I can apply them and send you one. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/