Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbaDVM2b (ORCPT ); Tue, 22 Apr 2014 08:28:31 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:49581 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932301AbaDVM21 (ORCPT ); Tue, 22 Apr 2014 08:28:27 -0400 MIME-Version: 1.0 X-Originating-IP: [95.21.51.154] In-Reply-To: References: <1396981215-24888-1-git-send-email-javier.martinez@collabora.co.uk> Date: Tue, 22 Apr 2014 14:28:25 +0200 Message-ID: Subject: Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations From: Javier Martinez Canillas To: Linus Walleij Cc: Javier Martinez Canillas , Alexandre Courbot , Mika Westerberg , Andy Shevchenko , Arnd Bergmann , Santosh Shilimkar , Kevin Hilman , "linux-gpio@vger.kernel.org" , Linux-OMAP , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Linus, On Tue, Apr 22, 2014 at 1:36 PM, Linus Walleij wrote: > On Tue, Apr 8, 2014 at 8:20 PM, Javier Martinez Canillas > wrote: > >> So this is an RFC patch-set to add a virtual table to be used by >> GPIO chip controllers and consist of the following patches: > > Overall I like this. > > However I don't want to see any transitional phase. I prefer a BIG > fat patch converting everyone and its dog to the new vtable and > removing the old function pointers. This can be based on the HEAD > of my GPIO devel branch. > Ok, I was adding a commit per GPIO driver but the patch-set would have been very big (~200 patches). > It may be a good idea to use coccinelle for this refactoring in order > not to miss any users. > Agreed, I was manually searching for users by using grep but I agree that is much safer to use coccinelle for this. I don't have previous experience writing coccinelle semantics patches though so it may take more time than I thought but it is the perfect excuse to finally learn how to do it :-) Thanks a lot and best regards, Javier > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/