Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S267138AbSKMH4F>; Wed, 13 Nov 2002 02:56:05 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S267142AbSKMH4F>; Wed, 13 Nov 2002 02:56:05 -0500
Received: from 167.imtp.Ilyichevsk.Odessa.UA ([195.66.192.167]:18440 "EHLO
	Port.imtp.ilyichevsk.odessa.ua") by vger.kernel.org with ESMTP
	id <S267138AbSKMH4D>; Wed, 13 Nov 2002 02:56:03 -0500
Message-Id: <200211130756.gAD7udp13264@Port.imtp.ilyichevsk.odessa.ua>
Content-Type: text/plain;
  charset="us-ascii"
From: Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua>
Reply-To: vda@port.imtp.ilyichevsk.odessa.ua
To: "J.A. Magall?n" <jamagallon@able.es>
Subject: Re: Some functions are not inlined by gcc 3.2, resulting code is ugly
Date: Wed, 13 Nov 2002 10:48:01 -0200
X-Mailer: KMail [version 1.3.2]
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <200211031125.gA3BP4p27812@Port.imtp.ilyichevsk.odessa.ua> <20021113012854.GA1806@werewolf.able.es> <200211130703.gAD73Up13033@Port.imtp.ilyichevsk.odessa.ua>
In-Reply-To: <200211130703.gAD73Up13033@Port.imtp.ilyichevsk.odessa.ua>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1058
Lines: 33

On 13 November 2002 09:54, Denis Vlasenko wrote:
> On 12 November 2002 23:28, J.A. Magall?n wrote:
> > On 2002.11.04 Denis Vlasenko wrote:
> > [...]
> >
> > > __constant_c_and_count_memset *has to* be inlined.
> > > There is large switch statement which meant to be optimized out.
> > > It does optimize out *only if* count is compile-time constant.
> >
> > I also got tons of __copy_to_user and __copy_from_user in 2.4.
> > Do not show in 2.5 ?
>
> I haven't looked.

I looked there, there is no _constant_XXX inlines in 2.5's uaccess.h

BTW, what a joy seeing sane asm formatting there!
No sight of '\t' ;)

BTW #2: in order to have sane asm formatting _and_ pretty asm
generated by GCC one would add "\n" after 'asm(':

	__asm__ __volatile__("\n" <---------------
                "1:	mov a,b\n"
		.....

--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/