Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755918AbaDVNBg (ORCPT ); Tue, 22 Apr 2014 09:01:36 -0400 Received: from service87.mimecast.com ([91.220.42.44]:40892 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbaDVNB2 convert rfc822-to-8bit (ORCPT ); Tue, 22 Apr 2014 09:01:28 -0400 Date: Tue, 22 Apr 2014 14:01:22 +0100 From: Liviu Dudau To: Jingoo Han Cc: "'Arnd Bergmann'" , "'linux-pci'" , "'Bjorn Helgaas'" , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , "'Kukjin Kim'" , "'Jason Gunthorpe'" , "'Mohit KUMAR DCG'" , "'Pratyush Anand'" , "'Marek Vasut'" , "'Richard Zhu'" , "'Kishon Vijay Abraham I'" , "'Byungho An'" , "'Rob Herring'" Subject: Re: [RFC PATCH 1/2] PCI: designware: Add ARM64 PCI support Message-ID: <20140422130122.GH865@e106497-lin.cambridge.arm.com> Mail-Followup-To: Jingoo Han , 'Arnd Bergmann' , 'linux-pci' , 'Bjorn Helgaas' , "linux-arm-kernel@lists.infradead.org" , "linaro-kernel@lists.linaro.org" , "linux-kernel@vger.kernel.org" , 'Kukjin Kim' , 'Jason Gunthorpe' , 'Mohit KUMAR DCG' , 'Pratyush Anand' , 'Marek Vasut' , 'Richard Zhu' , 'Kishon Vijay Abraham I' , 'Byungho An' , 'Rob Herring' References: <000801cf592e$30b7bff0$92273fd0$%han@samsung.com> <000901cf592e$563bc8c0$02b35a40$%han@samsung.com> <20140416165724.GG7802@e106497-lin.cambridge.arm.com> <16730530.rJ9T0MsYmt@wuerfel> <000001cf5d04$982a6000$c87f2000$%han@samsung.com> <000501cf5d48$4cf707c0$e6e51740$%han@samsung.com> MIME-Version: 1.0 In-Reply-To: <000501cf5d48$4cf707c0$e6e51740$%han@samsung.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 22 Apr 2014 13:01:38.0728 (UTC) FILETIME=[FF9EFA80:01CF5E2A] X-MC-Unique: 114042214012600601 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 21, 2014 at 10:58:52AM +0100, Jingoo Han wrote: > On Monday, April 21, 2014 10:54 AM, Jingoo Han wrote: > > On Thursday, April 17, 2014 3:26 AM, Arnd Bergmann wrote: > > > On Wednesday 16 April 2014 17:57:24 Liviu Dudau wrote: > > > > Jingoo, > > > > > > > > Thanks for taking a stab at trying to convert a host bridge > > > > driver to use the new generic host bridge code. > > > > > > > > I do however have concerns on the direction you took. You have split > > > > your driver in two, depending on whether it was CONFIG_ARM or CONFIG_ARM64, > > > > even if (with my series) it should be no reason why the host bridge > > > > driver should not work on other architectures as well once they are > > > > converted. > > > > > > Right. > > > > > > > Also, some of the functions that you use have identical names but different > > > > signatures depending on what arch you have selected. This is really bad > > > > in my books! > > [.....] > > > > > What about creating functions that use my series directly if CONFIG_ARM64 is > > > > defined (or any CONFIG_ you want to create for your driver that you select > > > > from CONFIG_ARM64) and otherwise implement the CONFIG_ARM version? That > > > > way your driver will call only one API without any #ifdef and when arm code > > > > gets converted you drop your adaptation functions. Or (better yet), have a > > > > stab at converting bios32 (Rob Herring has already provided some hints on > > > > how to do it for arch/arm). > > > > To: Liviu Dudau > > > > Sorry, but I will not implement this. > > At first, you had to think the compatibility with ARM32 PCIe. > > Why do you want other engineers to take this load? > > (+cc Rob Herring) > > Um, I am looking at Rob Herring's patchset for Versatile PCI. [1] > Then, do you mean the following? > > 1. Add Rob Herring's patch converting bios32. [2] > 2. Reference Rob Herring's patch in order to know how to > handle "of_create_pci_host_bridge()" directly in ARM32. [3] > 3. Use of_create_pci_host_bridge() for the designware PCIe > driver in ARM32. > 4. Also, use of_create_pci_host_bridge() for the designware PCIe > driver in "ARM64". > Sounds like a good plan. 3 and 4 should be one and the same in my opinion, but there might be more things in designware driver that I am missing right now. Best regards, Liviu > > [1] http://www.spinics.net/lists/linux-pci/msg30084.html > [2] http://www.spinics.net/lists/linux-pci/msg30083.html > [3] http://www.spinics.net/lists/linux-pci/msg30086.html > > Best regards, > Jingoo Han > > > > > > > > > That would of course be best. > > > > > [.....] > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/