From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Subject: Re: [PATCH 14/28] nios2: DMA mapping API
Date: Tue, 22 Apr 2014 15:52:00 +0200
User-Agent: KMail/1.12.2 (Linux/3.8.0-22-generic; KDE/4.3.2; x86_64; ; )
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, lftan.linux@gmail.com,
        cltang@codesourcery.com
References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397845149-3141-1-git-send-email-lftan@altera.com> <1397845149-3141-4-git-send-email-lftan@altera.com>
In-Reply-To: <1397845149-3141-4-git-send-email-lftan@altera.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201404221552.00501.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org

On Friday 18 April 2014, Ley Foon Tan wrote:

> +static inline int dma_supported(struct device *dev, u64 mask)
> +{
> +	/* we fall back to GFP_DMA when the mask isn't all 1s,
> +	 * so we can't guarantee allocations that must be
> +	 * within a tighter range than GFP_DMA.
> +	 */
> +	if (mask < 0x00ffffff)
> +		return 0;
> +
> +	return 1;
> +}

> +void *dma_alloc_coherent(struct device *dev, size_t size,
> +			    dma_addr_t *dma_handle, gfp_t gfp)
> +{
> +	void *ret;
> +
> +	/* ignore region specifiers */
> +	gfp &= ~(__GFP_DMA | __GFP_HIGHMEM);
> +
> +	/* optimized page clearing */
> +	gfp |= __GFP_ZERO;
> +
> +	if (dev == NULL || (dev->coherent_dma_mask < 0xffffffff))
> +		gfp |= GFP_DMA;

What is the significance of ZONE_DMA on this architecture?

Do you actually have DMA masters with a 0x00ffffff mask?

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/