Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 13 Nov 2002 04:31:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 13 Nov 2002 04:31:53 -0500 Received: from dp.samba.org ([66.70.73.150]:44202 "EHLO lists.samba.org") by vger.kernel.org with ESMTP id ; Wed, 13 Nov 2002 04:31:51 -0500 From: Rusty Russell To: Zwane Mwaikambo Cc: Linux Kernel Cc: Linus Torvalds Subject: Re: [PATCH][2.5] smp_init 'CPUS done' looks strange In-reply-to: Your message of "Tue, 12 Nov 2002 22:50:38 CDT." Date: Wed, 13 Nov 2002 20:34:25 +1100 Message-Id: <20021113093843.52D432C0B0@lists.samba.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 17 In message you write: > Also, it would make sense in the future if smp_cpus_done actually gets a > value denoting how many cpus are online. No. Drop the prink by all means, but smp_cpus_done() can call num_online_cpus() itself. It can't know how many cpus the user specified, however. Rusty. -- Anyone who quotes me in their sig is an idiot. -- Rusty Russell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/