Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756292AbaDVOOk (ORCPT ); Tue, 22 Apr 2014 10:14:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19512 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbaDVOOh (ORCPT ); Tue, 22 Apr 2014 10:14:37 -0400 Date: Tue, 22 Apr 2014 17:14:17 +0300 From: Dan Carpenter To: navin patidar Cc: devel@driverdev.osuosl.org, Greg KH , linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function. Message-ID: <20140422141417.GM26890@mwanda> References: <1397983638-10752-1-git-send-email-navin.patidar@gmail.com> <1397983638-10752-3-git-send-email-navin.patidar@gmail.com> <20140422101101.GG26890@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote: > Hi dan > > it's just a cleanup patch and i also tested all patches of this patch > series on the hardware (TP-LINK TL-WN723N). > my mistake i should have added "Tested-by" tag for all patches. > > Tested-by: navin patidar No no. It's not necesary to add a tested by to everything. It was just something I was curious about. The patches looked ok. If you hadn't tested them I would review them a second time more carefully. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/