MIME-Version: 1.0
In-Reply-To: <20140422142613.GA14535@infradead.org>
References: <20140422142419.GD21121@dreric01-Precision-T1600>
	<20140422142613.GA14535@infradead.org>
Date: Tue, 22 Apr 2014 11:01:03 -0400
Message-ID: <CA+5PVA7TFXdK-KjbwUtqMPF6=Ot1yhKycg5naV6N_gALWVN7cg@mail.gmail.com>
Subject: Re: [PATCH] Export irq tracepoints for use by kernel modules
From: Josh Boyer <jwboyer@fedoraproject.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Drew Richardson <drew.richardson@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Joe Perches <joe@perches.com>, Ben Greear <greearb@candelatech.com>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, mathieu.desnoyers@efficios.com
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org

On Tue, Apr 22, 2014 at 10:26 AM, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Apr 22, 2014 at 07:24:20AM -0700, Drew Richardson wrote:
>> After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
>> Use struct pointer instead of name hash for reg/unreg tracepoints"),
>> any tracepoints used in a kernel module must be exported.
>
> How does this matter given that there aren't any modular users?

We had a bug report about this breaking systemtap type usage[1].  In
there, Matthieu suggested that the new for_each_kernel_tracepoint
interface be used.

Drew, it would have been proper to CC the author of the change you're
referencing on all of your patches to export these symbols.

josh

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1087623
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/