Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933147AbaDVQjA (ORCPT ); Tue, 22 Apr 2014 12:39:00 -0400 Received: from perceval.ideasonboard.com ([95.142.166.194]:47509 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757330AbaDVQi6 (ORCPT ); Tue, 22 Apr 2014 12:38:58 -0400 From: Laurent Pinchart To: Phil Edworthy , Simon Horman Cc: Linus Walleij , Guido Piasenza , Linux-SH , LKML Subject: Re: [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5 Date: Tue, 22 Apr 2014 18:39:06 +0200 Message-ID: <2172750.fMdy2nvht6@avalon> User-Agent: KMail/4.11.5 (Linux/3.12.13-gentoo; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1398180483-10651-1-git-send-email-phil.edworthy@renesas.com> References: <1398180483-10651-1-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Phil, Thank you for the patch. On Tuesday 22 April 2014 16:28:03 Phil Edworthy wrote: > From: Guido Piasenza > > The extra entry in the table makes SCIFA0_B, and all peripherals after it, > fail. > > Signed-off-by: Phil Edworthy Acked-by: Laurent Pinchart > --- > drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c > b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c index 4809371..dbf2ef9 100644 > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c > @@ -4795,7 +4795,7 @@ static const struct pinmux_cfg_reg > pinmux_config_regs[] = { /* IP5_23_21 [3] */ > FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4, > FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B, > - FN_IERX_C, 0, > + FN_IERX_C, I would have put that last entry at the end of the previous line, to have four entries on both lines. > /* IP5_20_18 [3] */ > FN_WE0_N, FN_IECLK, FN_CAN_CLK, > FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0, -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/