Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756370AbaDVWIM (ORCPT ); Tue, 22 Apr 2014 18:08:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44020 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbaDVWIK (ORCPT ); Tue, 22 Apr 2014 18:08:10 -0400 Date: Wed, 23 Apr 2014 01:07:57 +0300 From: Dan Carpenter To: Fabio Falzoi Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] Staging: rts5139: Use standard pr_ prefixing Message-ID: <20140422220757.GQ26890@mwanda> References: <1398201784-7602-1-git-send-email-fabio.falzoi84@gmail.com> <1398201784-7602-5-git-send-email-fabio.falzoi84@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398201784-7602-5-git-send-email-fabio.falzoi84@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 11:23:02PM +0200, Fabio Falzoi wrote: > Define pr_fmt macro to prefix every pr_ function in standard way. > In the end we will want to remove all these debugging messages. The error conditions probably already have a print, the function tracing is done better with ftrace, etc. Also the pr_ functions have fallen out of fashion and all the cool kids use dev_ prefixed printks now. (Doesn't really apply to this patch per se). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/