Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755206AbaDWDIF (ORCPT ); Tue, 22 Apr 2014 23:08:05 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:60331 "EHLO lgemrelse7q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbaDWDID (ORCPT ); Tue, 22 Apr 2014 23:08:03 -0400 X-Original-SENDERIP: 10.177.220.145 X-Original-MAILFROM: iamjoonsoo.kim@lge.com Date: Wed, 23 Apr 2014 12:08:55 +0900 From: Joonsoo Kim To: Weijie Yang Cc: Andrew Morton , Weijie Yang , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , Bob Liu , linux-kernel Subject: Re: [PATCH] zram: correct offset usage in zram_bio_discard Message-ID: <20140423030855.GB11184@js1304-P5Q-DELUXE> References: <000001cf5dd8$ecf1c360$c6d54a20$%yang@samsung.com> <20140422125539.f40a414ca0dbae703a23b977@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 23, 2014 at 10:32:30AM +0800, Weijie Yang wrote: > On Wed, Apr 23, 2014 at 3:55 AM, Andrew Morton > wrote: > > On Tue, 22 Apr 2014 11:14:02 +0800 Weijie Yang wrote: > > > >> we want to skip the logical block which is partially covered by > >> the discard bio, so check the remaining size and subtract it if > >> there is a need to goto the next logical block. > >> > >> This patch corrects the offset usage in zram_bio_discard. > >> > > > > What were the end-user visible effects of the bug? > > > > Please always include this information when fixing something so that > > others can work out which kernel(s) need patching. > > > > Thanks for your advise, I will resend this patch and add the end-user > visible effect information. Thanks for fixing it. As far as I understand, there is no end-user visible effect, because request size is alway PAGE_SIZE aligned and if n < PAGE_SIZE, no real operation happens. Am I missing? Anyway, Acked-by: Joonsoo Kim Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/