Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbaDWFZl (ORCPT ); Wed, 23 Apr 2014 01:25:41 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:55212 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbaDWFZi (ORCPT ); Wed, 23 Apr 2014 01:25:38 -0400 Date: Wed, 23 Apr 2014 00:25:34 -0500 From: Eric Biggers To: Dave Jones , Miklos Szeredi , Al Viro , Kernel Mailing List , Linux-Fsdevel Subject: Re: [PATCH] vfs: rw_copy_check_uvector() - free iov on error Message-ID: <20140423052534.GB2755@zzz.student-wireless07.macalester.edu> References: <20140415145749.GF10187@tucsk.piliscsaba.szeredi.hu> <20140416180422.GA20907@redhat.com> <20140421155020.GB13709@redhat.com> <20140422133835.GA32718@redhat.com> <20140423050639.GA2755@zzz.student-wireless07.macalester.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140423050639.GA2755@zzz.student-wireless07.macalester.edu> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 23, 2014 at 12:06:39AM -0500, Eric Biggers wrote: > The proposed patch doesn't work because in compat_rw_copy_check_uvector(), 'iov' > is incremented in the loop before it is freed or returned. This probably should > be changed to indexing with 'seg', like in the non-compat version... Also, there is still a memory leak in vmsplice() as it does not free the iov buffer if 0 is returned from rw_copy_check_uvector() (possible if all segments are of zero length). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/