Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757242AbaDWHYy (ORCPT ); Wed, 23 Apr 2014 03:24:54 -0400 Received: from mail-la0-f49.google.com ([209.85.215.49]:41381 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756728AbaDWHYv (ORCPT ); Wed, 23 Apr 2014 03:24:51 -0400 MIME-Version: 1.0 In-Reply-To: <20140422162432.GA17674@ravnborg.org> References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397824031-4892-5-git-send-email-lftan@altera.com> <20140422142443.GB15745@arch.cereza> <20140422151458.GC1053@distanz.ch> <20140422153522.GF15745@arch.cereza> <20140422162432.GA17674@ravnborg.org> Date: Wed, 23 Apr 2014 09:24:49 +0200 X-Google-Sender-Auth: M-5sBdJ98a4e573wjitlUzg-n7A Message-ID: Subject: Re: [PATCH 06/28] nios2: Memory management From: Geert Uytterhoeven To: Sam Ravnborg Cc: Ezequiel Garcia , Tobias Klauser , Ley Foon Tan , Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , LeyFoon Tan , cltang@codesourcery.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, On Tue, Apr 22, 2014 at 6:24 PM, Sam Ravnborg wrote: > #define PAGE_SIZE (_AC(1, UL) << PAGE_SHIFT) > #define PAGE_MASK (~(PAGE_SIZE-1)) > > _AC(1, UL) expands to 1 for assembler and 1UL for C code. Ideally, PAGE_SIZE should be size_t, not unsigned long, avoiding issues like https://lkml.org/lkml/2014/4/13/78. But currently it's unsigned long everywhere, so nios2 should be consistent. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/