Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753972AbaDWMQS (ORCPT ); Wed, 23 Apr 2014 08:16:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:7766 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbaDWMQK (ORCPT ); Wed, 23 Apr 2014 08:16:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,911,1389772800"; d="scan'208";a="525535628" Date: Wed, 23 Apr 2014 15:23:44 +0300 From: Mika Westerberg To: Adam Williamson Cc: Benjamin Tissoires , "Jin, Yao" , Linus Walleij , alan@linux.intel.com, mathias.nyman@intel.com, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA Message-ID: <20140423122344.GX30677@intel.com> References: <1397649959-29762-1-git-send-email-yao.jin@linux.intel.com> <5353A1F6.60602@linux.intel.com> <5353B8A4.1080900@linux.intel.com> <1398007690.2674.0.camel@adam.happyassassin.net> <5354BA59.2000008@linux.intel.com> <53551D0F.40906@linux.intel.com> <1398230210.2704.8.camel@adam.happyassassin.net> <20140423083430.GV30677@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140423083430.GV30677@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 23, 2014 at 11:34:30AM +0300, Mika Westerberg wrote: > On Tue, Apr 22, 2014 at 10:16:50PM -0700, Adam Williamson wrote: > > Well, I can't actually concur. See my results in > > https://bugzilla.kernel.org/show_bug.cgi?id=68291#c44 . > > > > 1. A kernel with neither patch applied (and no hid-rmi driver) results > > in a working touchscreen. > > 2. A kernel with only v3 of Doug's patch from > > https://bugzilla.kernel.org/show_bug.cgi?id=67921 results in a working > > touchscreen. > > 3. A kernel with both v3 of Doug's patch and this IRQ descriptor > > conflict "fix" results in a broken touchscreen. > > > > Seems to me there really is some kind of problem with this patch... > > Can you try so that you have both patches applied and then this one? I'm > suspecting that the ACPI GPIO operation region support might do something > unexpected in this case. I'm able to reproduce this problem here now and it seems not related to the ACPI GPIO operation regions. This patch changes call to irq_domain_add_linear() to irq_domain_add_simple() and somehow that changes the behaviour so that I get non-working touchscreen: ... [ 37.434998] i2c_hid i2c-ATML1000:00: failed to reset device. [ 37.435009] i2c_hid i2c-ATML1000:00: i2c_hid_set_power [ 37.435021] i2c_hid i2c-ATML1000:00: __i2c_hid_command: cmd=fb 00 01 08 [ 38.439897] i2c_hid i2c-ATML1000:00: can't add hid device: -61 [ 38.440749] i2c_hid: probe of i2c-ATML1000:00 failed with error -61 It never gets an interrupt when the device reset is ready. Jin, do you have any idea what is going on? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/