Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754235AbaDWMln (ORCPT ); Wed, 23 Apr 2014 08:41:43 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:47465 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755005AbaDWMli (ORCPT ); Wed, 23 Apr 2014 08:41:38 -0400 MIME-Version: 1.0 X-Originating-IP: [217.156.156.35] In-Reply-To: <201404231418.05174.arnd@arndb.de> References: <1398247687-13453-1-git-send-email-james.hogan@imgtec.com> <1398247687-13453-4-git-send-email-james.hogan@imgtec.com> <201404231418.05174.arnd@arndb.de> Date: Wed, 23 Apr 2014 13:41:37 +0100 X-Google-Sender-Auth: DnvbcFNxUo0iyUUjGomMrueoR4U Message-ID: Subject: Re: [RFC 3/3] asm-generic: Drop renameat syscall from default list From: James Hogan To: Arnd Bergmann , Miklos Szeredi Cc: linux-arch@vger.kernel.org, LKML , Vineet Gupta , Catalin Marinas , Will Deacon , ARM Kernel List , Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Richard Kuo , linux-hexagon@vger.kernel.org, metag , Jonas Bonn , linux@openrisc.net, Chen Liqin , Lennox Wu , Chris Metcalf , Guan Xuetao Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23 April 2014 13:18, Arnd Bergmann wrote: > On Wednesday 23 April 2014, James Hogan wrote: >> The new renameat2 syscall provides all the functionality provided by the >> renameat syscall and adds flags, so future architectures won't need to >> include renameat. >> >> Therefore drop the renameat syscall from the generic syscall list unless >> __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to >> including asm-generic/unistd.h, and adjust all architectures using the >> generic syscall list to define it so that no in-tree architectures are >> affected. > > I should have read this one before replying to patch 2 ;-) > >> Signed-off-by: James Hogan >> Cc: Arnd Bergmann >> Cc: linux-arch@vger.kernel.org >> Cc: Vineet Gupta >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: Mark Salter >> Cc: Aurelien Jacquiot >> Cc: linux-c6x-dev@linux-c6x.org >> Cc: Richard Kuo >> Cc: linux-hexagon@vger.kernel.org >> Cc: linux-metag@vger.kernel.org >> Cc: Jonas Bonn >> Cc: linux@lists.openrisc.net >> Cc: Chen Liqin >> Cc: Lennox Wu >> Cc: Chris Metcalf >> Cc: Guan Xuetao >> --- >> Is this the approach we want to take to keep the default syscall list >> minimal? We could for example have made renameat2 use the renameat >> syscall number for new arches, but it seemed best to leave a gap for new >> arches to improve consistency of numbering. > > I think leaving the hole is best. > >> This patch is a no-op for arches in tree, so there's no harm for this to >> wait for the v3.16 merge window. > > Sounds good. I guess I'll have to put this into my asm-generic tree > then, unless I can get the nios2 maintainers to pick it up. Okay, thanks. > If you don't mind, can you submit the first two patches to Linus > directly? It appears Miklos Szeredi beat me to it with patch 1 (adding renameat2 syscall to asm-generic unistd.h), and will be submitting it to Linus at some point as part of his renameat2 series. Miklos: Do you think it makes sense for you to include my second patch in your series too since it's renameat2 related? http://marc.info/?l=linux-kernel&m=139824773305016&w=2 Otherwise I'm happy to take it or both patches for v3.15. Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/