Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756498AbaDWNb3 (ORCPT ); Wed, 23 Apr 2014 09:31:29 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:52323 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756249AbaDWNbZ (ORCPT ); Wed, 23 Apr 2014 09:31:25 -0400 MIME-Version: 1.0 In-Reply-To: <1398194284.7767.101.camel@deadeye.wl.decadent.org.uk> References: <1395873465-22282-1-git-send-email-zoltan.kiss@citrix.com> <20140327.152956.1528740039185894234.davem@davemloft.net> <20140421112601.GC3200@hercules> <1398181118.3624.203.camel@deadeye.wl.decadent.org.uk> <5356AEBF.5010505@citrix.com> <1398194284.7767.101.camel@deadeye.wl.decadent.org.uk> Date: Wed, 23 Apr 2014 09:31:25 -0400 X-Google-Sender-Auth: OQePyeWCFiBYlFoGc091G4qZTR8 Message-ID: Subject: Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors From: Josh Boyer To: Ben Hutchings Cc: Zoltan Kiss , Luis Henriques , David Miller , jesse@nicira.com, pshelar@nicira.com, Thomas Graf , dev@openvswitch.org, pablo@netfilter.org, kadlec@blackhole.kfki.hu, edumazet@google.com, Daniel Borkmann , Tom Herbert , jasowang@redhat.com, fw@strlen.de, Joe Perches , horms@verge.net.au, jiri@resnulli.us, mst@redhat.com, Paul.Durrant@citrix.com, Jan Beulich , Herbert Xu , mszeredi@suse.cz, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, xen-devel@lists.xenproject.org, netdev , "Linux-Kernel@Vger. Kernel. Org" , KVM list Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 22, 2014 at 3:18 PM, Ben Hutchings wrote: > From: Zoltan Kiss > > commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream. > > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well, and modify the callers accordingly. skb_tx_error() is also added to > the callers so they will signal the failed delivery towards the creator of the > skb. > > Signed-off-by: Zoltan Kiss > Signed-off-by: David S. Miller > [bwh: Backported to 3.13: skb_zerocopy() is new in 3.14, but was moved from a > static function in nfnetlink_queue. We need to patch that and its caller, but > not openvswitch.] > Signed-off-by: Ben Hutchings Deja-vu. I sent almost the same patch to netdev a while ago and you acked it there. So I guess I'll ack your copy as well :). Not sure why either version wasn't picked up by Dave. josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/