Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756791AbaDWNkp (ORCPT ); Wed, 23 Apr 2014 09:40:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10754 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755140AbaDWNkk (ORCPT ); Wed, 23 Apr 2014 09:40:40 -0400 Message-ID: <5357C2D2.5060700@redhat.com> Date: Wed, 23 Apr 2014 09:40:34 -0400 From: Daniel J Walsh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Eric Paris , Steve Grubb CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-audit@redhat.com, selinux@tycho.nsa.gov, jamal@mojatatu.com, davem@davemloft.net Subject: Re: [PATCH 0/6][v2] audit: implement multicast socket for journald References: <20140422.161904.1187535812839850973.davem@davemloft.net> <26389161.vp9iWSVLPX@x2> <1398225475.750.7.camel@localhost> In-Reply-To: <1398225475.750.7.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Here are the capabilities we currently give to sysadm_t with sysadm_secadm 1.0.0 Disabled allow sysadm_t sysadm_t : capability { chown dac_override dac_read_search fowner fsetid kill setgid setuid setpcap linux_immutable net_bind_service net_broadcast net_admin net_raw ipc_lock ipc_owner sys_rawio sys_chroot sys_ptrace sys_pacct sys_admin sys_boot sys_nice sys_resource sys_time sys_tty_config mknod lease audit_write setfcap } ; allow sysadm_t sysadm_t : capability { setgid setuid sys_chroot } allow sysadm_t sysadm_t : capability2 { syslog block_suspend } ; cap_audit_write might be a problem? On 04/22/2014 11:57 PM, Eric Paris wrote: > On Tue, 2014-04-22 at 22:25 -0400, Steve Grubb wrote: >> On Tuesday, April 22, 2014 09:31:52 PM Richard Guy Briggs wrote: >>> This is a patch set Eric Paris and I have been working on to add a >>> restricted capability read-only netlink multicast socket to kernel audit to >>> enable userspace clients such as systemd/journald to receive audit logs, in >>> addition to the bidirectional auditd userspace client. >> Do have the ability to separate of secadm_r and sysadm_r? By allowing this, we >> will leak to a sysadmin that he is being audited by the security officer. In a >> lot of cases, they are one in the same person. But for others, they are not. I >> have a feeling this will cause problems for MLS systems. > Why? This requires CAP_AUDIT_READ. Just don't give CAP_AUDIT_READ to > places you don't want to have read permission. Exactly the same as you > don't give CAP_AUDIT_CONTROL to sysadm_r. (If we are giving > CAP_AUDIT_CONTROL to sysadm_r and you think that any file protections > on /var/log/audit/audit.log are adequate we are fooling ourselves!) > >> Also, shouldn't we have an audit event for every attempt to connect to this >> socket? We really need to know where this information is getting leaked to. > We certainly can. What would you like to see in that event? > > -Eric > > _______________________________________________ > Selinux mailing list > Selinux@tycho.nsa.gov > To unsubscribe, send email to Selinux-leave@tycho.nsa.gov. > To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/